X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from nm35-vm7.bullet.mail.ne1.yahoo.com (nm35-vm7.bullet.mail.ne1.yahoo.com [98.138.229.103]) by mail.alpinelinux.org (Postfix) with SMTP id F0FB9DC0150 for ; Fri, 6 Apr 2012 17:20:38 +0000 (UTC) Received: from [98.138.90.51] by nm35.bullet.mail.ne1.yahoo.com with NNFMP; 06 Apr 2012 17:20:38 -0000 Received: from [98.138.89.246] by tm4.bullet.mail.ne1.yahoo.com with NNFMP; 06 Apr 2012 17:20:38 -0000 Received: from [127.0.0.1] by omp1060.mail.ne1.yahoo.com with NNFMP; 06 Apr 2012 17:20:38 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 302807.359.bm@omp1060.mail.ne1.yahoo.com Received: (qmail 34615 invoked by uid 60001); 6 Apr 2012 17:20:37 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1333732837; bh=kNRqZcxBvYBen45WmMTYagHT2NKe8ooksPdvfapbzK8=; h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type; b=XCGD66ewTieywytdlyGFwvkssKd5RQtRjQOpziBr1/OVYIR2x/Ni+g252ckqaurnGLPCfQ4D738g90gv1DdBx5YK07JcK5M/j1vPT5TilelyCxvl/9ZH30h+kZGrG3jjunPsnFIYiZhDg3y8x76YJWlTQmbuaIWZ2mqCGgH7p8U= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type; b=DAc4fGNGwgxQVZoWoPl05nqG2Umd/Xr5yhjkyE8kGAjmr4mMESqGG16Cz2txCTcPBwa8J/mJ7ENxsmbs4rE/EKQYvbCqfMZtBXK/TMdbcyE2bQdjFif479JINxfRykzTiPTGwig4MHsVyZgCvRDeqozSeKt0AKrUQ3W8rnLgidA=; X-YMail-OSG: AAjjPuEVM1nA1Nm4aaRcUqB0N3AA9lqJ2tzJoof7abYtKCm njZIwyERB.dsCD1guMt8RlJBK7IalXe_OlFPmGiBB47aV3H4pj_mADdnUe7F KTYpqYrDjezoJkP4q9MI8Uo5t5fNVdYiYQ2f9S41FiTBrie6E4AcT__fo65n RvFFRt5Q3rbYhpxBvbm_glwHc68lMvWSdrL46fOLEM3cvs1aMWCXmEDUCCof iyzqJtWXkxX0nYzUW4SliAAWrQVIy4it7DfIL6_ws1iQTZ14aMXZXHGjrpHd WUztBVsUpcPTEXLIsjUMPTFFNss2sBbt_Lx1HMyernVosZmrF8wK37vMjJZv lAkFgCAsKh8.lXVgBJkAtEah1Yy_VQhiIysCKtO.IIfaJNFjjLPHko1yAKD0 uBd2dTQBMI5ERxVY_wTGJDTF2CsHegf44stfMinKn6tv9yxZDU2CjGVaTzmA ihv3n0HgTSB0MGQdAsvYCh.xNVU9I3nif9OrpEA-- Received: from [71.65.233.159] by web130105.mail.mud.yahoo.com via HTTP; Fri, 06 Apr 2012 10:20:37 PDT X-Mailer: YahooMailWebService/0.8.117.340979 References: <4F6E1119.8080306@arcor.de> Message-ID: <1333732837.18993.YahooMailNeo@web130105.mail.mud.yahoo.com> Date: Fri, 6 Apr 2012 10:20:37 -0700 (PDT) From: Ted Trask Reply-To: Ted Trask Subject: Re: [alpine-devel] [Patch] acf-iptables: fixing model To: Der Tiger , "alpine-devel@lists.alpinelinux.org" In-Reply-To: <4F6E1119.8080306@arcor.de> X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="1819627952-618091252-1333732837=:18993" --1819627952-618091252-1333732837=:18993 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Thank you for the patch, and sorry for the long delay before properly respo= nding. Unfortunately, the bugs you found were not the only ones present. I = guess acf-iptables hadn't been tested in a while. Please see=A0http://git.a= lpinelinux.org/cgit/acf-iptables/commit/?id=3Dce765fba9cf9fd1c4b1981ab137df= 35c4b662b04 for the changes I committed. Please try using the file http://g= it.alpinelinux.org/cgit/acf-iptables/tree/iptables-model.lua to make sure I= fixed your reported problems. Once I hear back from you, I'll feel more co= nfident in bumping the package version.=0A=0ATed=0A=0A=0A__________________= ______________=0A From: Der Tiger =0ATo: alpine-= devel@lists.alpinelinux.org =0ASent: Saturday, March 24, 2012 2:23 PM=0ASub= ject: [alpine-devel] [Patch] acf-iptables: fixing model=0A =0AHi,=0A=0ATher= e are two bugs causing the web interface to malfunction when either=0Aa pro= tocol selection is negated using a exclamation mark (!) or a=0Acomment is e= ntered in the appropriate field of the form.=0A=0APLEASE, make sure removin= g the escaping of the spec string does not=0Acause problems with certain da= ta entered in the form! So far, I had no=0Atroubles while testing, because = the fields are checked in=0Avalidate_rule(), anyway.=0A=0ARegards, Tiger=0A= =0A--- /usr/share/acf/app/iptables/iptables-model.lua.orig=0A+++ /usr/share= /acf/app/iptables/iptables-model.lua=0A@@ -147 +147 @@=0A-=A0 =A0 addparame= ter(rule.value.protocol.value, "-p")=0A+=A0 =A0 addparameter(rule.value.pro= tocol.value, "-p", true)=0A@@ -520 +520 @@=0A-=A0 =A0 =A0 =A0 local cmd =3D= path .. "iptables -t " ..=0Aformat.escapespecialcharacters(rule.value.tabl= e.value) .. " -R " ..=0Aformat.escapespecialcharacters(rule.value.chain.val= ue) .. " " ..=0Aformat.escapespecialcharacters(rule.value.position.value) .= . " " ..=0Aformat.escapespecialcharacters(spec) .. " 2>&1"=0A+=A0 =A0 =A0 = =A0 local cmd =3D path .. "iptables -t " ..=0Aformat.escapespecialcharacter= s(rule.value.table.value) .. " -R " ..=0Aformat.escapespecialcharacters(rul= e.value.chain.value) .. " " ..=0Aformat.escapespecialcharacters(rule.value.= position.value) .. " " .. spec=0A.. " 2>&1"=0A=0A=0A=0A---=0AUnsubscribe:= =A0 alpine-devel+unsubscribe@lists.alpinelinux.org=0AHelp:=A0 =A0 =A0 =A0 = alpine-devel+help@lists.alpinelinux.org=0A--- --1819627952-618091252-1333732837=:18993 Content-Type: text/html; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable
Thank you = for the patch, and sorry for the long delay before properly responding. Unf= ortunately, the bugs you found were not the only ones present. I guess acf-= iptables hadn't been tested in a while. Please see http://git.alpineli= nux.org/cgit/acf-iptables/commit/?id=3Dce765fba9cf9fd1c4b1981ab137df35c4b66= 2b04 for the changes I committed. Please try using the file http://git.alpi= nelinux.org/cgit/acf-iptables/tree/iptables-model.lua to make sure I fixed = your reported problems. Once I hear back from you, I'll feel more confident= in bumping the package version.

Ted

From: Der Tiger <der.tiger.alp= ine@arcor.de>
To: a= lpine-devel@lists.alpinelinux.org
Subject: [alpine-devel] [Patch] acf-iptables:= fixing model

=0AHi,

There are two bugs causi= ng the web interface to malfunction when either
a protocol selection is = negated using a exclamation mark (!) or a
comment is entered in the appr= opriate field of the form.

PLEASE, make sure removing the escaping o= f the spec string does not
cause problems with certain data entered in t= he form! So far, I had no
troubles while testing, because the fields are= checked in
validate_rule(), anyway.

Regards, Tiger

--- /u= sr/share/acf/app/iptables/iptables-model.lua.orig
+++ /usr/share/acf/app= /iptables/iptables-model.lua
@@ -147 +147 @@
-    addparame= ter(rule.value.protocol.value, "-p")
+    addparameter(rule.va= lue.protocol.value, "-p", true)
@@ -520 +520 @@
-     =   local cmd =3D path .. "iptables -t " ..
format.escapespecialchar= acters(rule.value.table.value) .. " -R " ..
format.escapespecialcharacte= rs(rule.value.chain.value) .. " " ..
format.escapespecialcharacters(rule.value.position.value) .. " " ..<= br>format.escapespecialcharacters(spec) .. " 2>&1"
+   =     local cmd =3D path .. "iptables -t " ..
format.escapespec= ialcharacters(rule.value.table.value) .. " -R " ..
format.escapespecialc= haracters(rule.value.chain.value) .. " " ..
format.escapespecialcharacte= rs(rule.value.position.value) .. " " .. spec
.. " 2>&1"


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:        = alpine-devel+help@lists.alpinelinux.org
---


--1819627952-618091252-1333732837=:18993-- --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---