From: Hugo Landau <hlandau@devever.net>
To: alpine-devel@lists.alpinelinux.org
Cc: Hugo Landau <hlandau@devever.net>
Subject: [alpine-devel] [PATCH] Fixed postfix bug causing postconf -m to segfault
Date: Tue, 23 Apr 2013 18:11:19 +0000
Message-Id: <1366740679-25308-1-git-send-email-hlandau@devever.net>
Precedence: list

Running postconf -m resulted in a segfault and no output.
The bug originated in dynamic-maps3.patch. postconf_other.c was modified by
this patch such that it called concatenate(), but the file was not modified to
include <stringops.h>, resulting in the function being undeclared. This
resulted in gcc incorrectly assuming a default prototype for it with return
type int instead of char*, causing pointer truncation on 64-bit systems,
causing a segfault when the truncated pointer is passed to another function.
The fix is to #include <stringops.h> in postconf_other.c. The patch has been
updated.

I don't have abuild 2.14 on this machine so I'll leave updating the SHA256
checksums to whoever commits it.
---
 main/postfix/dynamic-maps3.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/main/postfix/dynamic-maps3.patch b/main/postfix/dynamic-maps3.patch
index 0e5a3c9..81848ab 100644
--- a/main/postfix/dynamic-maps3.patch
+++ b/main/postfix/dynamic-maps3.patch
@@ -311,7 +311,7 @@ index 04f9404..1752450 100644
 +/* Global library. */
 +
 +#include <mail_params.h>
-+
++#include <stringops.h>
  /* Application-specific. */
  
  #include <postconf.h>
-- 
1.8.0



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---