IronPort-SDR: WKXBybjPeKIheAx0ndILHla//C1C97aA2bbWHpXuuLpObLIANEGxyhvjcKmGSpw2i3iR3OBVIa
 QwIO73NaoySg==
IronPort-PHdr: =?us-ascii?q?A9a23=3AbgHViRemrP5lA9xU8yQ8j4GMlGM/QIqcDmcuA?=
 =?us-ascii?q?tIPlL9EcqO449L+MU/E7OtznRnCWoCIjpAMw6Ke++ioEXcY78OZuWsZONxXW?=
 =?us-ascii?q?hkJhN9evjRoAdXNUBWkaqe1PmpgRJoEDg4kt2q+LVATHc//Y1PIpXjn4TAeA?=
 =?us-ascii?q?gj1MQt+Dvv0HoLOgs+32Omo95DVJQ5BzCG4fas0LBiyqlDi75hMx9I8euBqj?=
 =?us-ascii?q?EKZ804gRg=3D=3D?=
IronPort-Data: =?us-ascii?q?A9a23=3AONMijqibPytInpZIWrBE87qHX161vRIKZh0uj?=
 =?us-ascii?q?C45NGQN5FlHY01jehtvCziAP//YNjSjL9p/bY219E4OvZXcxtVjQVZtrik9F?=
 =?us-ascii?q?X4W8JqUDtmwEBz9bniYRiHhoOKLzCm/huEtpanYd1eEzvuWGuWn/CMUOZ2gH?=
 =?us-ascii?q?OKmUrabYnopHGeIdQ944f5ds79h6mJXqYXha++9kYuaT/z3YDdJ6RYtWo4nw?=
 =?us-ascii?q?/jrRCdUgRjHkGhwUmrSxRx8lAS2e3E9VPrzLEwqRpfyatE88uWSH44vwFwll?=
 =?us-ascii?q?49wEspENz+rrlr7WhVirr/6IgWEin1NR+6+jxtZrzIsw+AwM/90hUV/0W3Px?=
 =?us-ascii?q?o0ojooW88XpFW/FPYWV8AgZexVWHzljN6lH85fYIHyzrcGYz0LPaXfhxbNlB?=
 =?us-ascii?q?SnaOKVBqrktXT4TpKRwxDclK0rra/iN6LSwTfFlrs0nNMjtMYcevGxwizbDA?=
 =?us-ascii?q?p4OV5nHW6TM6JhU0Sk9guhKHO3CfIwQbSJuahnEYhtSKhEQEp1WoQsCrhETa?=
 =?us-ascii?q?BVHpViVorErpXTezxd4zqb8dtHSf7S3qQxuth7wjgr7E67RW3n27OCi9Ac?=
 =?us-ascii?q?=3D?=
IronPort-HdrOrdr: =?us-ascii?q?A9a23=3A3PFQP6yJPU2SMMay52X/KrPwD71zdoMgy1?=
 =?us-ascii?q?knxilNoHxuH/BwWfre+MjzpiWE6gr5P0tQ4uxoWZPwOU80kKQe3WB/B9mftW?=
 =?us-ascii?q?XdyQ2VxcRZnPLfKl7behEWlNQz6U4IScEXY+EcFWIXsS+52njeLz9K+qjlzE?=
 =?us-ascii?q?nHv5a6854gd2FXgyYL1XYCNu4ceHcGOTV7OQ=3D=3D?=
Received-SPF: pass (webhost.teksavvy.com: connection is authenticated)
Message-ID: <13b60f0f-3095-49b9-5553-91963aebe319@wildtechgarden.ca>
Date: Sat, 2 Jul 2022 02:12:45 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: Fixing shell script libraries like /lib/libalpine.sh
Content-Language: en-CA
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: ~alpine/devel@lists.alpinelinux.org
References: <4caa8c5f-7ebf-ad2f-0e92-29428785fe60@wildtechgarden.ca>
 <20220701112124.7cd30d2e@ncopa-desktop.lan>
From: "Daniel F. Dickinson" <dfdpublic@wildtechgarden.ca>
In-Reply-To: <20220701112124.7cd30d2e@ncopa-desktop.lan>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 2022-07-01 5:21 a.m., Natanael Copa wrote:
> On Thu, 30 Jun 2022 02:16:49 -0400
> "Daniel F. Dickinson" <dfdpublic@wildtechgarden.ca> wrote:
>
>> Hello,
>>
>> I've noticed some issues with the Alpine shell script libraries (one
>> example below)[1]
>>
>> I'm new to Alpine but not to Linux, *BSD, or (way back) Ultrix, and have
>> not (yet) dug into the Alpine code base and infrastructure. (Although I
>> have my 'notes-to-self' documentation[2] that I intend (RSN...) to
>> integrate into the Wiki and have published on my website).
>>
>> My questions with respect to the issues mentioned are:
>>
>> 1. Do you prefer the GitLab merge request interface or the mailing list
>> for patches?[3]
> gitlab.
>  
>> 2. If you are not already using tools like shellcheck / shellfmt and or
>> shell unit tests in your CI, do you have objections to such being added?
> as long as it does not 

Er, I presume you meant to complete that thought? I hope my response to
Jakub clarifies what I'm thinking, and might address the concern you
were going to express.

>  
>> I'm hoping to spend some time fixing this type of issue as they result
>> in annoying hiccups when trying to automate setup-alpine, and I'd like
>> that to work well.
> I'm working on the testsuite to add tests to make sure setup-alpine
> works with an "answer file".
Awesome! I saw you pushed them in Gitlab recently. I look forward to
trying them out.
>> A final note: I've got some cloud-init image creation using Packer
>> that I soon intend to push to public repository, along with Terraform
>> usage of the same; is there interest in those here? I almost forgot;
>> what is the status the work on the 'tiny' cloud-init substitute or
>> other alternatives in Alpine?
> I intend to make some kind of tiny-cloud nocloud provider, which will
> be able to take some sort of cloud-init compatible config for
> unattended installs.

Sounds good. If I can help, please let me know.

>
>> Regards,
>>
>> Daniel
>>
>>
>> [1]:
>>
>> # test the first argument against the remaining ones, return success
>> on a match
>> isin() {
>>     local _a=$1 _b
>>     shift
>>     for _b; do
>>         [ "$_a" = "$_b" ] && return 0
>>     done
>>     return 1
>> }
>>
>> _b is never assigned a value.
> This is not true.

Yes, I read it wrong. As you point out it was a different issue, and you
have fixed both the docs and the setup-ntp issue that were the real
culprits.

>     for _b; do ...
>
> is equivalent to
>
>     for _b in "$@"; do ...
>
> So `isin "$resp" busybox openntpd chrony none abort; do` will iterate over
> "busybox openntpd chrony none abort" and return 0 (success) if $resp is
> in the listed options or 1 (failure) otherwise.
>
> See
> https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_09_04_03
>
>> This is why automating ntp setup fails
>> (specifically the following code in /sbin/setup-ntp) will never skip
>> the 'ask':
>>
>> while [ $# -eq 0 ] && ! isin "$resp" busybox openntpd chrony none abort; do
>>     ask "Which NTP client to run? ('busybox', 'openntpd', 'chrony' or
>> 'none')" chrony
>> done
> I believe there is other problem.
> (I noticed you filed a bug. I will have a look at it)
>
> -nc

Regards,

Daniel

-- 
https://wildtechgarden.ca Technical and professional website
https://princesandmadmen.ca Personal and political blog