From nobody Thu Mar 28 17:02:43 2024 X-Original-To: alpine-devel@mail.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 869E5DC12FB for ; Sun, 11 Oct 2015 15:50:18 +0000 (UTC) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 479AADC00BB for ; Sun, 11 Oct 2015 15:50:18 +0000 (UTC) Received: by wiclk2 with SMTP id lk2so123916023wic.1 for ; Sun, 11 Oct 2015 08:50:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=RL08B5CLtxYiry5Z1GqcwSwja8AOEdECBrc64r3eqro=; b=egjchPLKJPk3Wiyo2wfX/kPK0QoxIFYleKEttAey8xMSsrRFahKZWxXOaiwOpHyt8T On8dIF48xoLtdSRqcmUBckR9FIHK7694CCla8lyccbdhB3ISUguaKHcrF5tU2QD+0NJg dlNr0bnuVGFuh2EwPvO373LgwCT4Jh95qj2kAWiL1bKsng1W/JtXOQY+UM0iEhXJ5XZr 08zSL5iCajVSapK+F6QVgkoeeYtAv/EpQH8DwF7R3zw5+nSzv18tw2SK/MZjwEXEbYy4 RIuHEae2wzHasCI4Lvo6XPjYbHOlfYxB7Ha7su5c8sUvs9Jr8pO2TNKjnzJTSxb9SSS/ CqPg== X-Gm-Message-State: ALoCoQnv04uiOTz+7styA7J02EsPDq/0Ovg3t5DEx6NA4AcTGCrLxg+Sue/iVSM4Pktj2WP+BXzU X-Received: by 10.194.179.137 with SMTP id dg9mr25555851wjc.55.1444578616549; Sun, 11 Oct 2015 08:50:16 -0700 (PDT) Received: from localhost (pD9578B12.dip0.t-ipconnect.de. [217.87.139.18]) by smtp.gmail.com with ESMTPSA id ki7sm14436634wjc.28.2015.10.11.08.50.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Oct 2015 08:50:15 -0700 (PDT) From: Christian Kampka To: alpine-devel@lists.alpinelinux.org Subject: [alpine-devel] features should be read from $basedir if set Date: Sun, 11 Oct 2015 17:50:06 +0200 Message-Id: <1444578607-15095-1-git-send-email-christian@kampka.net> X-Mailer: git-send-email 2.6.1 X-Virus-Scanned: ClamAV using ClamSMTP X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: Hi, I noticed some strage behaviour with mkinitfs when running it against a different basedir using the -b switch. Apparently, it loads modules to be included in the initramfs from $basedir, but the list of modules defined through the features is not. This is quite inconsistent as those two things don't necessarily fit together, producing inusable initramfs images. The attached patch proposes to read features for initramfs from $basedir if set, assuming that this behavour is not intentionally the way it is now. Cheers, Christian --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org --- From nobody Thu Mar 28 17:02:43 2024 X-Original-To: alpine-devel@mail.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id A718FDC9A1C for ; Sun, 11 Oct 2015 15:50:23 +0000 (UTC) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 58F81DC6B1B for ; Sun, 11 Oct 2015 15:50:23 +0000 (UTC) Received: by wicge5 with SMTP id ge5so123124984wic.0 for ; Sun, 11 Oct 2015 08:50:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4Pwu37Ec8Sr9ZteaOFkkB7jKyYG8UviIW8R3jXjFLqw=; b=L3alH34XfSUDQj5yC4cmQFs8BAPGkzz8MFwninanfu0i5LXcayKnc8paEME2zhcKcz 5HDCiVpU0RzQaN56lMHbYvxg3a0FKt0+oyDo3coaYdjKQ3hmeki+72OInXcWath0qpTO z3yJjqPe7/p/8Y4PGtiGao88XtBxRfInMiY9docgnQo02zgqyb2eWkVP116lz3cL53RJ 4wiHsgWL3ZjjyBgHdDOenXy94rApW85TvSN2tOdijLUrahMIvX2DrTDJWsMfj08RrFKM +4tizXI5pEoKllSs/JyToZD2Ods1IobedErC4zEPwcRRWaYElJBwKMvT3GNazatPqFu+ yEGQ== X-Gm-Message-State: ALoCoQmv0s7yItvoeckuc4H+1/3SYgO19+O6A5JyT686LAdY8z842GQdATUaTJlGRu+gOZ1SppKr X-Received: by 10.180.105.66 with SMTP id gk2mr10456344wib.69.1444578621765; Sun, 11 Oct 2015 08:50:21 -0700 (PDT) Received: from localhost (pD9578B12.dip0.t-ipconnect.de. [217.87.139.18]) by smtp.gmail.com with ESMTPSA id it4sm14481371wjb.0.2015.10.11.08.50.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Oct 2015 08:50:20 -0700 (PDT) From: Christian Kampka To: alpine-devel@lists.alpinelinux.org Cc: Christian Kampka Subject: [alpine-devel] [PATCH] mkinitfs: features should be read from $basedir if set Date: Sun, 11 Oct 2015 17:50:07 +0200 Message-Id: <1444578607-15095-2-git-send-email-christian@kampka.net> X-Mailer: git-send-email 2.6.1 In-Reply-To: <1444578607-15095-1-git-send-email-christian@kampka.net> References: <1444578607-15095-1-git-send-email-christian@kampka.net> X-Virus-Scanned: ClamAV using ClamSMTP X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: --- mkinitfs.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkinitfs.in b/mkinitfs.in index d2a7890..14c728f 100755 --- a/mkinitfs.in +++ b/mkinitfs.in @@ -184,7 +184,7 @@ done shift $(( $OPTIND - 1 )) . $(readlink -f "$config") -features_dir=${features_dir:-"$sysconfdir/features.d"} +features_dir=${features_dir:-"${basedir%/:-}/${sysconfdir#/}/features.d"} [ -n "$myfeatures" ] && features="$myfeatures" if [ -n "$list_features" ]; then -- 2.6.1 --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org --- From nobody Thu Mar 28 17:02:43 2024 X-Original-To: alpine-devel@mail.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 888BCDC0137 for ; Tue, 20 Oct 2015 09:29:54 +0000 (UTC) Received: from newmail.tetrasec.net (unknown [74.117.189.116]) by mail.alpinelinux.org (Postfix) with ESMTP id 69830DC009F for ; Tue, 20 Oct 2015 09:29:54 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by newmail.tetrasec.net (Postfix) with ESMTPSA id BCB595A803B; Tue, 20 Oct 2015 09:19:23 +0000 (GMT) Date: Tue, 20 Oct 2015 11:29:48 +0200 From: Natanael Copa To: Christian Kampka Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] features should be read from $basedir if set Message-ID: <20151020112948.48592e50@ncopa-desktop.alpinelinux.org> In-Reply-To: <1444578607-15095-1-git-send-email-christian@kampka.net> References: <1444578607-15095-1-git-send-email-christian@kampka.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP On Sun, 11 Oct 2015 17:50:06 +0200 Christian Kampka wrote: > Hi, > > I noticed some strage behaviour with mkinitfs when running it against > a different basedir using the -b switch. Apparently, it loads modules > to be included in the initramfs from $basedir, but the list of > modules defined through the features is not. This is quite > inconsistent as those two things don't necessarily fit together, > producing inusable initramfs images. > > The attached patch proposes to read features for initramfs from > $basedir if set, assuming that this behavour is not intentionally the > way it is now. I don't think this was intentional and the patch looks correct. Thanks! -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---