Message-ID: <1485328750.11710.54.camel@gmail.com>
Subject: Re: [alpine-devel] [PATCH] setup-apkrepos: fix detect fastest
 mirror - fixes #6683
From: Leonardo Arena <rnalrd@gmail.com>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: alpine-devel@lists.alpinelinux.org
Date: Wed, 25 Jan 2017 08:19:10 +0100
In-Reply-To: <1485274245.11710.44.camel@gmail.com>
References: <1485272345-14166-1-git-send-email-rnalrd@gmail.com>
	 <20170124165812.685f5714@ncopa-desktop.copa.dup.pw>
	 <1485274245.11710.44.camel@gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-nt+XNclIyyTtwfY+ovJD"
Precedence: list
Mime-Version: 1.0


--=-nt+XNclIyyTtwfY+ovJD
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mar, 2017-01-24 at 17:10 +0100, Leonardo Arena wrote:
> On mar, 2017-01-24 at 16:58 +0100, Natanael Copa wrote:
> >=20
> > On Tue, 24 Jan 2017 16:39:05 +0100
> > rnalrd@gmail.com wrote:
> >=20
> > >=20
> > >=20
> > > From: Leonardo Arena <rnalrd@gmail.com>
> > >=20
> > > ---
> > > =C2=A0setup-apkrepos.in | 4 +++-
> > > =C2=A01 file changed, 3 insertions(+), 1 deletion(-)
> > >=20
> > > diff --git a/setup-apkrepos.in b/setup-apkrepos.in
> > > index 4565852..f4d4709 100644
> > > --- a/setup-apkrepos.in
> > > +++ b/setup-apkrepos.in
> > > @@ -51,7 +51,7 @@ find_fastest_mirror() {
> > > =C2=A0	for url in $MIRRORS; do
> > > =C2=A0		# warm up the dns cache
> > > =C2=A0		nslookup $(get_hostname_from_url $url)
> > > >/dev/null
> > > 2>&1
> > > -		local time=3D$(time_cmd wget -q -s -T 5 \
> > > +		local time=3D$(time_cmd wget -q -S -T 5 \
> > > =C2=A0			${url%/}/edge/main/$arch/APKINDEX.tar.gz
> > > )
> > > =C2=A0		if [ -n "$time" ]; then
> > > =C2=A0			echo "$time $url"
> > > @@ -204,6 +204,8 @@ if [ -n "$JUSTADDRANDOM" ]; then
> > > =C2=A0fi
> > > =C2=A0
> > > =C2=A0if [ -n "$JUSTADDFASTEST" ]; then
> > > +	# need GNU wget
> > > +	apk add wget --quiet
> > > =C2=A0	show_mirror_list > /dev/null
> > > =C2=A0	add_fastest_mirror && changed=3Dtrue
> > > =C2=A0fi
> > I dont think we should pull in gnu wget since we then would need to
> > have it on the iso.
> >=20
> > I think there is a wget --spider option that should work for
> > busybox
> > too.
> >=20
> > https://git.busybox.net/busybox/commit/?id=3D2972e2c4acb9c46a8cc05c85
> > 7a
> > cac2b3d439bf69
> >=20
> > -nc
>=20
> Well, edge still has 1.26. So I did it with what was available :)
> Nice option though!
>=20

I misread the commit message like there was version 1.28 out, but
instead it talks about GNU wget 1.18.
I guess I shouldn't look at this stuff when I'm in rush to the end of
working day :-)

-|_eo
--=-nt+XNclIyyTtwfY+ovJD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJYiFFuAAoJELAPckZGG2T6eCAH/iyEVxhhMkm0ZGs+nQ7Ed9qb
Zj3YFT1UWWasxNL4TpzqZdWFD6/sibXuFuPPP7cwLtiN3GYbEzbKcLQ30rHIjyD7
WpsBvAk7+wqaBOX6txdimll9TpcTaKOnCIxvQPaorFjS4cEDA037+x5Chce1juEj
VDx/f1O1Uk5ZmRTeMX31MBq4wTe10+ZXz4a7rZLoDeBueiz2x58Gs4nE/JKLl5Pn
mfCA1eKSpwqFdsbQdOqz8Ajympj/w8vwfkvCCu4gCdHnJYgdXm5lYQ3zbaz+mt37
BeSw16CtKbqW5XiXlmbEGRDeXbKP6ECBor6SFR85mGJYb5/amRLgNjf5AK5a64Y=
=pwTl
-----END PGP SIGNATURE-----

--=-nt+XNclIyyTtwfY+ovJD--



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---