Message-Id: <1532897225.933218.1456675080.62DDC693@webmail.messagingengine.com>
From: "Jean-Louis Fuchs" <ganwell@fangorn.ch>
To: alpine-devel@lists.alpinelinux.org
Precedence: list
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: multipart/alternative; boundary="_----------=_15328972259332181"
References: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw>
Date: Sun, 29 Jul 2018 13:47:05 -0700
In-Reply-To: <20180726141558.2d451763@ncopa-desktop.copa.dup.pw>
Subject: Re: [alpine-devel] How to improve quality control for patch reviews

This is a multi-part message in MIME format.

--_----------=_15328972259332181
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"

Hi

On Thu, Jul 26, 2018, at 05:15, Natanael Copa wrote:
> - give more people push access. Look for people that are candidates to>   get push access. Help them to improve. Follow up when they are "good>   enough".

In theory you don't need push access to review a PR:

- If there is a problem anybody can state it on github or the
  mailinglist- If one thinks the PR is ok one can write "looks good to me"

Idea: maybe it is possible that more people are allowed to add a label: "looks good", but without push access. So people with push access can work faster.
Best,
Jean-Louis

--_----------=_15328972259332181
Content-Transfer-Encoding: 7bit
Content-Type: text/html; charset="utf-8"

<!DOCTYPE html>
<html>
<head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body><div>Hi</div>
<div><br></div>
<div>On Thu, Jul 26, 2018, at 05:15, Natanael Copa wrote:<br></div>
<blockquote type="cite"><div>- give more people push access. Look for people that are candidates to<br></div>
<div>&nbsp; get push access. Help them to improve. Follow up when they are "good<br></div>
<div>&nbsp; enough".<br></div>
</blockquote><div><br></div>
<div>In theory you don't need push access to review a PR:<br></div>
<div><br></div>
<div>- If there is a problem anybody can state it on github or the mailinglist<br></div>
<div>- If one thinks the PR is ok one can write "looks good to me"<br></div>
<div><br></div>
<div>Idea: maybe it is possible that more people are allowed to add a label: "looks good", but without push access. So people with push access can work faster.<br></div>
<div><br></div>
<div>Best,<br></div>
<div>Jean-Louis</div>
</body>
</html>

--_----------=_15328972259332181--



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---