X-Original-To: alpine-devel@lists.alpinelinux.org Received: from mout.gmx.com (mout.gmx.com [74.208.4.201]) by lists.alpinelinux.org (Postfix) with ESMTP id 253475C4F24 for ; Mon, 17 Jul 2017 08:46:59 +0000 (GMT) Received: from [192.168.1.2] ([178.8.56.27]) by mail.gmx.com (mrgmxus001 [74.208.5.15]) with ESMTPSA (Nemesis) id 0LcSyO-1dwz5f0lj4-00jsPx; Mon, 17 Jul 2017 10:46:45 +0200 Subject: Re: [alpine-devel] Re: [alpine-aports] [PATCH] main/mkinitfs: backport cryptdiscards patch To: alpine-devel@lists.alpinelinux.org, soeren@soeren-tempel.net References: <20170610100553.3112-1-soeren+git@soeren-tempel.net> <20170612113737.0d96dd0a@ncopa-desktop.copa.dup.pw> <20170612105504.GA22141@francium> <20170614152710.4f52282a@ncopa-desktop.copa.dup.pw> <20170614214434.GA17311@francium> <20170616181142.28b8a187@ncopa-desktop.copa.dup.pw> <20170622154836.GA3263@francium> <20170714145955.GA17438@francium> From: 7heo <7heo@mail.com> Message-ID: <1865c521-d1f1-3e7e-eb3f-e32898a3e7c2@mail.com> Date: Mon, 17 Jul 2017 10:46:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 In-Reply-To: <20170714145955.GA17438@francium> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:ZvJARGOqvvXe+gZM4C0YTy2RrYsVnNAZFfWSY1H49+ybugUZjoM Q4QU03jQPm5WWvlCJqx0bynUrZxdb4Py/dfibX8jHZsfqt7oGguzT2+a9l+LvDyZE3MluJR uEM4dHIXSaeK+NLSwZ7fxLABfloiEFYcloTB+HkHkYzNvqCcZwnJXd0dX/AuwE1YE4TcPbo VVu3AgVUBQEHhRYHnDQTQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:d/Z9PXNzss0=:/a6+4dETEIn+ywBsii7y9v ZAjTf+ca2mfT4gol7EMgp4SQXYe8AZkGgj2BZvBGegt8736XZkKTPEAeCpsVq8ncvo08zKjyF YDpFF3bq3//N1VVZt3QVcVv6/B8bOb10WWmYdb8VThrqu6/V1PA96BJqN55Guun5jAlBVQGHY FSVmfaUKsPtF/McIlV23AVbdmsBeoNnxcrusov+mcZ/xteV6vXo8+yDCFSeHSyukdOh12nYcu DJATeNazjcGDysZnMOQYKbb59QMCnCQV5hIpl0xvc0NqPypVwmtlpEaiHW8R3fa8h+EZZ/g5z d/TlTUW/ds/q8Szbg/PUr0fY2EQfUlGCGzvUg2JYxydnrtETiNI167XKIxAqNSV629z1B/ENc geJ+E/oMf5TVPzuWG9TEfp9bBdsDv7xv3E6qIIT4ExcY8Oo3uA3A6Y/0flX1SqOONg31OH8JO nE3E3dtiPRmAN4Goc0pQ5Fal9OXhmxf1zLX+q7aNjEcsCeD/sd8qV6GSQsHpz0uHkuZ+ZIbAJ 4275kiZyHMWfkSxjtNZky6AD1oH7Z/NgUFIL7YvXx1Kh3Sp+2UuW+hRvbpdbzZCUhKZzeODBW rtkAGXvNBRjK20cgbxndp+aUc/V5RPFCGZuk73+kTX4tTrxZ42eMG50C0Lh9KRqWPVcLSBDj8 kWPEooxYUS5nilwmF08bU5FqYrshzwxi3i09/if/4zxbLr+8voqBgYgZNGh/MkLi4IoN03r7x +sVOAua8GDeyWnj/tmDPaNfkjv6gnwwAt6nQ6QTPd9L15oEBTiaOM/LhXdcKQ0OaFOiJXF8aT UbB+WeEYK2SAL9USRixaWevDlXVOTF18v4F0xGDC3xkKFOAm3s= On 7/14/2017 4:59 PM, S=F6ren Tempel wrote: > Ping? > > On 22.06.17, S=F6ren Tempel wrote: >> On 16.06.17, Natanael Copa wrote: >>> Does anybody on alpine-devel have opinion on what the boot args should >>> be for LUKS devices? >> >> Doesn't seem to be the case. How about merging this into the mkinitfs >> repository without backporting it for now? We can still change the name >> of the kernel parameters later on. >> >> Cheers, >> S=F6ren Hey there, Sorry for the lag, I couldn't answer in Friday and then the week end got=20 in the way. However, I prefer the separated-variables way, and by far. Here is the=20 reasoning: - The parsing would happen in shell (as opposed as in the initfs binary)=20 and I don't think doing unnecessary (for appearance only) text parsing=20 in shell is the sane way to go. - Using ':' (or anything else really) as separator is assuming that this=20 character isn't used in any identifier in the list. In the past, present=20 and future. For any of those identifiers, ever. And really, we cannot=20 assume that. - Separating variables with their name is way more explicit and way less=20 magic than establishing an arbitrary order and relying on the users to=20 read the documentation on what a variable does, and in what order. - Having multiple variables grouped where it is technically incorrect=20 will be misleading and confusing, teaching newcomers the wrong lessons. * * * Long story short, I do not think that the cost (purely visual) of having=20 the variables separated in the configuration file is worth the technical=20 effort and technical risk of concatenating them. KISS. HTH 7heo --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---