For discussion of Alpine Linux development and developer support

1

[alpine-devel] new aport clamsmtp

Carlo Landmeter
Details
Message ID
<20090203114416.2654C188BAC@smtp01.prioritytelecom.nl>
Sender timestamp
1233661455
DKIM signature
missing
Download raw message
see attached git patch
Natanael Copa
Details
Message ID
<1233670686.6926.77.camel@nc>
In-Reply-To
<20090203114416.2654C188BAC@smtp01.prioritytelecom.nl> (view parent)
Sender timestamp
1233670686
DKIM signature
missing
Download raw message
On Tue, 2009-02-03 at 11:44 +0000, Carlo Landmeter wrote:
> From f1ce4e56e76edddbe583d01ad0289aba952f73ca Mon Sep 17 00:00:00 2001
> From: Carlo Landmeter <clandmeter@gmail.com>
> Date: Tue, 3 Feb 2009 11:42:48 +0000
> Subject: [PATCH] extra/clamstmp: new aport

maybe add pkg desc and url in the commit message for new aports in
future?

it is handy when looking at the commit logs

> ---
> diff --git a/extra/clamsmtp/clamsmtp.confd
> b/extra/clamsmtp/clamsmtp.confd
> new file mode 100644
> index 0000000..a2c9cf5
> --- /dev/null
> +++ b/extra/clamsmtp/clamsmtp.confd
> @@ -0,0 +1,5 @@
> +#
> +# Specify daemon $OPTS here.
> +#
> +
> +OPTS="-p /var/run/clamsmtpd.pid"

I dont think the pidfile shoudl be a configuration option since its set
hard in the init.d script...

> diff --git a/extra/clamsmtp/clamsmtp.initd
> b/extra/clamsmtp/clamsmtp.initd
> new file mode 100644
> index 0000000..4ccfe6c
> --- /dev/null
> +++ b/extra/clamsmtp/clamsmtp.initd
> @@ -0,0 +1,25 @@
> +#!/sbin/runscript
> +
> +# Sample init.d file for alpine linux.
> +
> +NAME=clamsmtpd
> +DAEMON=/usr/sbin/$NAME
> +
> +depend() {
> +       need net clamd
> +}
> +
> +start() {
> +       ebegin "Starting ${NAME}"
> +               start-stop-daemon --start --quiet \
> +                       --exec ${DAEMON} -- ${OPTS}

...so we should set the pidfile hard here too and not in the conf.d:

                   --exec ${DAEMON} -- ${OPTS} -p /var/run/$NAME.pid

> +       eend $?
> +}
> +
> +stop() {
> +       ebegin "Stopping ${NAME}"
> +               start-stop-daemon --stop --quiet \
> +                       --exec ${DAEMON} \
> +                       --pidfile /var/run/${NAME}.pid
> +       eend $?
> +}
> -- 
> 1.6.1


I committed it anyway.

Thanks!

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---