X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@lists.alpinelinux.org
Received: from mail.wtbts.no (mail.wtbts.no [213.234.126.131])
	by lists.alpinelinux.org (Postfix) with ESMTP id D89321EBFF1
	for <alpine-devel@lists.alpinelinux.org>; Tue,  4 Jan 2011 12:08:04 +0000 (UTC)
Received: from localhost (bsna.nor.wtbts.net [127.0.0.1])
	by mail.wtbts.no (Postfix) with ESMTP id D5D33AE4002;
	Tue,  4 Jan 2011 12:08:03 +0000 (UTC)
X-Virus-Scanned: Yes
Received: from mail.wtbts.no ([127.0.0.1])
	by localhost (bsna.nor.wtbts.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id tjV+v2Y7NiCX; Tue,  4 Jan 2011 12:08:02 +0000 (UTC)
Received: from mail.ytre.org (extmail.nor.wtbts.net [10.65.72.14])
	by mail.wtbts.no (Postfix) with ESMTP id 64808AE4001;
	Tue,  4 Jan 2011 12:08:02 +0000 (UTC)
Received: from mail.ytre.org (localhost [127.0.0.1])
	by mail.ytre.org (Postfix) with ESMTP id 0AA4D60A89E56;
	Tue,  4 Jan 2011 12:08:02 +0000 (UTC)
Received: from ncopa-desktop.nor.wtbts.net (unknown [10.65.65.1])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: ncopa@ytre.org)
	by mail.ytre.org (Postfix) with ESMTPSA id A7ED160A89E52;
	Tue,  4 Jan 2011 12:08:01 +0000 (UTC)
Date: Tue, 4 Jan 2011 13:09:16 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Francesco <francesco.colista@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] new aport: libbsd
Message-ID: <20110104130916.67bc1c0f@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <AANLkTinxMhcR0MnL5S+KDxiTkX2-SkuwkDaUNH+7+z_=@mail.gmail.com>
References: <AANLkTinxMhcR0MnL5S+KDxiTkX2-SkuwkDaUNH+7+z_=@mail.gmail.com>
X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.1; x86_64-unknown-linux-gnu)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV using ClamSMTP

Hi,

Please use git send-email when sending patches then i can apply the
directly from mutt rather than manually do 'save attachemnt', scp to
dev box, git am, rm <patch>.

http://alpinelinux.org/wiki/Development_using_git#Submitting_patches_to_the_alpine-devel_mailing_list

On Tue, 4 Jan 2011 09:21:00 +0100
Francesco <francesco.colista@gmail.com> wrote:

> Subject: [PATCH] new aport

only 'new aport' in git commit log is not very helpful since it does
not show in the log what aport it is.

Please use 'testing/libbsd: new aport' as first line in commit.

Then its helpful to have the package description and url listed in the
commit message.

Then you can easily see and find info what the new package is about
when browsing the aports trere via cgit.
for example:
http://git.alpinelinux.org/cgit/aports/commit/?id=7269013bc00062d01ca5bb2ad4fd55cf5bcd9887

> 
> ---
>  testing/libbsd/APKBUILD |   35 +++++++++++++++++++++++++++++++++++
>  1 files changed, 35 insertions(+), 0 deletions(-)
>  create mode 100644 testing/libbsd/APKBUILD
> 
> diff --git a/testing/libbsd/APKBUILD b/testing/libbsd/APKBUILD
> new file mode 100644
> index 0000000..ea54453
> --- /dev/null
> +++ b/testing/libbsd/APKBUILD
> @@ -0,0 +1,35 @@
> +# Contributor: Francesco Colista <francesco.colista@gmail.com>
> +# Maintainer: Francesco Colista <francesco.colista@gmail.com>
> +
> +pkgname=libbsd
> +pkgver=0.2.0
> +pkgrel=0
> +pkgdesc="Provides useful functions commonly found on BSD systems
> like strlcpy()" +arch="x86 x86_64"
> +url="http://libbsd.freedesktop.org"
> +license="custom"
> +depends="uclibc-dev"

never add uclibc-dev to depends (unless you have a good reason for it).
The uclibc-dev dependency is automatically pulled in by build-base
which is automatically added to all makedepends.

> +makedepends=
> +install=
> +subpackages=""
> +source="http://libbsd.freedesktop.org/releases/$pkgname-$pkgver.tar.gz"
> +
> +# append extra dependencies to -dev subpackage
> +# remove if not used.
> +# depends_dev="somepackage-dev"

Those comments should be removed.
> +
> +_builddir="$srcdir"/$pkgname-$pkgver
> +
> +build() {
> +	cd "$_builddir"
> +	
> +	make exec_prefix=/usr includedir=/usr/include/libbsd ||
> return 1 +}
> +
> +package() {
> +	cd "$_builddir"
> +
> +	make exec_prefix=/usr includedir=/usr/include/libbsd
> DESTDIR=$pkgdir install +}

separate package() function. good!

> +
> +md5sums="c6d5413e76949b14e4bf13258e63d355  libbsd-0.2.0.tar.gz"


I looked at the build output and it created development files
(/usr/include/*.h /usr/lib/pkgconfig/ ) and doc files. I think you
should add:

subpackages="$pkgname-dev $pkgname-doc"

Can you please fix those things and resend the patch?

You can do: git reset HEAD^ to undo a commit or git commit --amend to
redo it.

Thanks!

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---