Date: Sat, 5 Feb 2011 11:02:50 +0100
From: Juraj Sujan <sujan@sofy.sk>
To: Timo =?UTF-8?Q?Ter=C3=A4s?= <timo.teras@iki.fi>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] maildrop:  new aport
Message-ID: <20110205110250.7508e5e2@alpine.sofy.sk>
In-Reply-To: <4D4D134F.5060108@iki.fi>
References: <20110204234736.2b4ac96c@alpine.sofy.sk>
	<4D4D134F.5060108@iki.fi>
Precedence: list
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/JY/xLg=B3xUWmsjW1msNrb+"

--MP_/JY/xLg=B3xUWmsjW1msNrb+
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Sat, 05 Feb 2011 11:07:27 +0200
Timo Ter=C3=A4s <timo.teras@iki.fi> wrote:

> I get:
>=20
> make[1]: Entering directory
> `/home/tteras/aports/testing/maildrop/src/maildrop-2.5.2/maildrop'
> make[1]: *** No rule to make target `all'.  Stop.
> make[1]: Leaving directory
> `/home/tteras/aports/testing/maildrop/src/maildrop-2.5.2/maildrop'
> make: *** [all-recursive] Error 1
> >>> ERROR: maildrop: all failed
>=20
> This happened on two separate chroot's with latest edge packages.

That's strange, because it is working fine for me. It looks like
configure script has failed. The only reason I can think of is missing
libstdc++ dependancy, so I've included it in makedepends.

>=20
> Also the commit message is usually formatted like
> "testing/maildrop: new aport"

done

> It would be also nice if you listed the upstream source for the patch,
> since it looks pretty large. There's also whitespace issues in the
> patch but that's likely upstream fault so it's okish.

fixed, patch is now sourced from upstream

> Otherwise it looks good to me. So if we get it to build I'm happy to
> push this. :)

Thank you for suggestions. I hope it will be ok now.

Juraj

--MP_/JY/xLg=B3xUWmsjW1msNrb+
Content-Type: text/x-patch
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename=0001-testing-maildrop-new-aport.patch

>From 67374e03a38decb5551f6b9dc179bacea88e2b3f Mon Sep 17 00:00:00 2001
From: Juraj Sujan <sujan@sofy.sk>
Date: Sat, 5 Feb 2011 10:49:53 +0100
Subject: [PATCH] testing/maildrop: new aport

---
 testing/maildrop/APKBUILD |   42 ++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 42 insertions(+), 0 deletions(-)
 create mode 100644 testing/maildrop/APKBUILD

diff --git a/testing/maildrop/APKBUILD b/testing/maildrop/APKBUILD
new file mode 100644
index 0000000..74574cf
--- /dev/null
+++ b/testing/maildrop/APKBUILD
@@ -0,0 +1,42 @@
+# Contributor: Juraj Sujan <sujan@sofy.sk>
+# Maintainer: Juraj Sujan <sujan@sofy.sk>
+pkgname=maildrop
+pkgver=2.5.2
+pkgrel=0
+pkgdesc="Mail delivery agent with filtering abilities"
+url="http://courier-mta.org/maildrop/"
+arch="all"
+license="GPL3"
+depends=
+makedepends="libstdc++ pcre-dev"
+install=
+subpackages="$pkgname-doc"
+source="http://downloads.sourceforge.net/project/courier/$pkgname/$pkgver/$pkgname-$pkgver.tar.bz2
+	http://www.max.rs/ozone/maildrop-2.3.0-dovecotauth.patch.txt"
+
+_builddir="$srcdir"/$pkgname-$pkgver
+
+prepare() {
+	cd "$_builddir"
+	# apply patches here
+	if ! patch --verbose -p1 -i ../maildrop-2.3.0-dovecotauth.patch.txt; then
+		error "dovecotauth patch failed"
+		return 1
+	fi
+}
+
+build() {
+	cd "$_builddir"
+	./configure --prefix=/usr --disable-authlib --without-db
+	make || return 1
+}
+
+package() {
+	cd "$_builddir"
+	make DESTDIR="$pkgdir" install
+	mkdir "$pkgdir"/usr/share/doc
+	mv "$pkgdir"/usr/share/maildrop "$pkgdir"/usr/share/doc/
+	cp README.dovecotauth "$pkgdir"/usr/share/doc/maildrop/
+}
+md5sums="3edb56534ae442a494255db6c8aaab99  maildrop-2.5.2.tar.bz2
+f5e0fd910d76c4fba2a5fcdd40c6b375  maildrop-2.3.0-dovecotauth.patch.txt"
-- 
1.7.3.5


--MP_/JY/xLg=B3xUWmsjW1msNrb+--


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---