Date: Sat, 25 Jun 2011 20:03:44 +0200
From: Paul Onyschuk <blink@bojary.koba.pl>
To: Fabian Affolter <fabian@affolter-engineering.ch>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] weplab APKBUILD
Message-Id: <20110625200344.26051046.blink@bojary.koba.pl>
In-Reply-To: <4E0611C5.3020306@affolter-engineering.ch>
References: <4E0611C5.3020306@affolter-engineering.ch>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 25 Jun 2011 18:50:13 +0200
Fabian Affolter <fabian@affolter-engineering.ch> wrote:

> 
> Hi all,
> 
> Some minutes ago I sent an initial APKBUILD for weplab [1] to this
> list. It's my first package for Alpine Linux and because of that I
> really would like to get some feedback.
> 
> Thanks in advance.
> 

Hi Fabian. I'm not experienced with aports either, but I can point out
few thing.

Option "depends_dev" is used to specify dependencies of dev subpackage. 
It's pretty common that "makedepends" shares some entries with
"depends_dev", but with weplab it isn't the case - weplab doesn't have
dev subpackage.

So you need only: makedepends="libpcap-dev wireless-tools-dev"

Secondly intructions like install should be always included in
package() section. Nice thing about aports is that, you can run commands
like "abuild prepare", "abuild build" and so on. Putting "install" in
build() section pretty much kills purpose of this separation.

On the side notes, I don't see any reason why you should provide weplab
package with license file. Weblap uses standard license (GPL2) and ain't
no library.

Rest is fine :)

Cheers.

-- 
Paul Onyschuk <blink@bojary.koba.pl>


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---