X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from mail.wtbts.no (mail.wtbts.no [213.234.126.131])
	by mail.alpinelinux.org (Postfix) with ESMTP id 2611F130E4D8
	for <alpine-devel@lists.alpinelinux.org>; Mon, 27 Jun 2011 08:31:40 +0000 (UTC)
Received: from localhost (bsna.nor.wtbts.net [127.0.0.1])
	by mail.wtbts.no (Postfix) with ESMTP id 70DCCAE4002;
	Mon, 27 Jun 2011 08:31:38 +0000 (UTC)
X-Virus-Scanned: Yes
Received: from mail.wtbts.no ([127.0.0.1])
	by localhost (bsna.nor.wtbts.net [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id R4O0L2LTs9y0; Mon, 27 Jun 2011 08:31:36 +0000 (UTC)
Received: from mail.ytre.org (extmail.nor.wtbts.net [10.65.72.14])
	by mail.wtbts.no (Postfix) with ESMTP id 83472AE4001;
	Mon, 27 Jun 2011 08:31:36 +0000 (UTC)
Received: from mail.ytre.org (localhost [127.0.0.1])
	by mail.ytre.org (Postfix) with ESMTP id 38E9660A804D0;
	Mon, 27 Jun 2011 08:31:36 +0000 (UTC)
Received: from ncopa-desktop.nor.wtbts.net (ncopa-desktop.nor.wtbts.net [10.65.65.1])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: ncopa@ytre.org)
	by mail.ytre.org (Postfix) with ESMTPSA id DE4E260A804CB;
	Mon, 27 Jun 2011 08:31:35 +0000 (UTC)
Date: Mon, 27 Jun 2011 10:27:23 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Fabian Affolter <fabian@affolter-engineering.ch>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] Initial APKBUILD for Alpine Linux
Message-ID: <20110627102723.5398b6bf@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <1309020273-5144-1-git-send-email-fabian@affolter-engineering.ch>
References: <Fabian Affolter <fabian@affolter-engineering.ch>
	<1309020273-5144-1-git-send-email-fabian@affolter-engineering.ch>
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.5; x86_64-unknown-linux-gnu)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV using ClamSMTP

Hi Fabian,

Thanks for a very nice first APKBUILD!

On Sat, 25 Jun 2011 16:44:33 +0000
Fabian Affolter <fabian@affolter-engineering.ch> wrote:

> ---
>  testing/weplab/APKBUILD |   34 ++++++++++++++++++++++++++++++++++
>  1 files changed, 34 insertions(+), 0 deletions(-)
>  create mode 100644 testing/weplab/APKBUILD
> 
> diff --git a/testing/weplab/APKBUILD b/testing/weplab/APKBUILD

You placed the new aport in testing/ and not main/ Good!

> new file mode 100644
> index 0000000..9117f53
> --- /dev/null
> +++ b/testing/weplab/APKBUILD
> @@ -0,0 +1,34 @@
> +# Contributor: Fabian Affolter <fabian@affolter-engineering.ch>
> +# Maintainer:

Contributor but not maintainer. You normally don't start as maintainer.
Good!

> +pkgname=weplab
> +pkgver=0.1.5
> +pkgrel=0
> +pkgdesc="Analyzing WEP encryption security on wireless networks"

Short and nice description. Good!

> +url="http://weplab.sourceforge.net/"
> +arch="all"
> +license="GPLv2+"
> +depends=
> +depends_dev="libpcap-dev wireless-tools-dev"
> +makedepends="$depends_dev"

Paul commented about depends_dev. The above is not wrong though.

> +install=""
> +subpackages="$pkgname-doc"
> +source="http://downloads.sourceforge.net/$pkgname/$pkgname-$pkgver.tar.gz"
> +
> +_builddir="$srcdir"/$pkgname-$pkgver
> +
> +build() {
> +	cd "$_builddir"
> +    ./configure \
> +        --prefix=/usr \
> +        --mandir=/usr/share/man \
> +        || return 1
> +	make || return 1
> +    install -Dm 644 COPYING
> "$pkgdir"/usr/share/licenses/$pkgname/COPYING +}

installing license belongs to package() as Paul said. I think just
setting license is good enough in GPLv2+ since its a standard
license and people normally understand what that means.

> +
> +package() {
> +	cd "$_builddir"
> +	make DESTDIR="$pkgdir" install || return 1
> +}
> +
> +md5sums="713870965447b0b8b7341409968846fb  weplab-0.1.5.tar.gz"

Very good first APKBUILD!

Maybe the commit message could have been better. Maybe something like:

testing/weplab: new aport

<description>
<url>


Applied and took maintainership.
Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---