Date: Mon, 27 Jun 2011 10:49:30 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Fabian Affolter <fabian@affolter-engineering.ch>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] Initial APKBUILD of halberd
Message-ID: <20110627104930.14a46e55@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <1309038270-10413-1-git-send-email-fabian@affolter-engineering.ch>
References: <1309038270-10413-1-git-send-email-fabian@affolter-engineering.ch>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

You got "halberd" in the summary line in commit message. Good!

On Sat, 25 Jun 2011 21:44:30 +0000
Fabian Affolter <fabian@affolter-engineering.ch> wrote:

> ---
>  testing/halberd/APKBUILD |   42
> ++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 42
> insertions(+), 0 deletions(-) create mode 100644
> testing/halberd/APKBUILD
> 
> diff --git a/testing/halberd/APKBUILD b/testing/halberd/APKBUILD
> new file mode 100644
> index 0000000..bc62684
> --- /dev/null
> +++ b/testing/halberd/APKBUILD
> @@ -0,0 +1,42 @@
> +# Contributor: Fabian Affolter <fabian@affolter-engineering.ch>
> +# Maintainer:
> +pkgname=halberd
> +pkgver=0.2.4
> +pkgrel=0
> +pkgdesc="Tool to discover HTTP load balancers"

Nice and short description. Good!

> +url="http://halberd.superadditive.com"
> +arch="noarch"
> +license="GPL2+"
> +depends="python"

We dont have any special magic for autodetecting python dependency so
adding python to depends is correct. Good!

> +makedepends="python-dev "
> +install=""
> +subpackages="$pkgname-doc"
> +source="http://$pkgname.superadditive.com/dist/$pkgname-$pkgver.tar.gz
> +        $pkgname-sslwrap.patch"
> +
> +_builddir="$srcdir"/$pkgname-$pkgver
> +
> +prepare() {
> +	cd "$_builddir"
> +	patch -p1 -i "$srcdir"/$pkgname-sslwrap.patch || return 1
> +}

Applying patches in prepare section. Good!

> +
> +build() {
> +	cd "$_builddir"
> +	python setup.py build || return 1
> +}
> +
> +package() {
> +	cd "$_builddir"
> +	python setup.py bdist_dumb --keep-temp --bdist-dir "$pkgdir"
> || return 1 +}
> +
> +doc() {
> +    # The man page is not picked-up automatically
> +	mkdir -p "$subpkgdir"/usr/share/man || return 1
> +    mv "$_builddir"/man/man* "$subpkgdir"/usr/share/man/ || return 1
> +}

Moving manpage to proper location. Good!

> +
> +
> +md5sums="d60d0fba8f379ea72c623ad1dd6052c3  halberd-0.2.4.tar.gz
> +1fe48ed2a0ef58e8a387ab23368d637c  halberd-sslwrap.patch"

md5sum: can't open 'halberd-sslwrap.patch': No such file or directory

I think you forgot to 'git add halberd-sslwrap.patch' before you did
git commit.

Care to send a new patch?

You can use 'git add --amend ....' to redo a commit in your local git
repo.

Thanks!


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---