Date: Tue, 12 Jul 2011 10:20:23 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: John Keith Hohm <john@hohm.net>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/mtr: new aport
Message-ID: <20110712102023.10ce93fe@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <1310419297-15518-1-git-send-email-john@hohm.net>
References: <1310419297-15518-1-git-send-email-john@hohm.net>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 11 Jul 2011 16:21:37 -0500
John Keith Hohm <john@hohm.net> wrote:

> Full screen ncurses traceroute tool
> http://www.bitwizard.nl/mtr/
> ---
>  testing/mtr/APKBUILD              |   48 +++++
>  testing/mtr/mtr-res_mkquery.patch |  374
> +++++++++++++++++++++++++++++++++++++ 2 files changed, 422
> insertions(+), 0 deletions(-) create mode 100644 testing/mtr/APKBUILD
>  create mode 100644 testing/mtr/mtr-res_mkquery.patch


Thanks!
Looks generally good. Some minor notes below.

...

> +depends_dev="ncurses-dev"
> +makedepends="$depends_dev"
> +install=""
> +subpackages="$pkgname-doc"

Since there are no mtr-dev subpackage you could have just deleted
depends_dev.

...
> +++ b/testing/mtr/mtr-res_mkquery.patch
> @@ -0,0 +1,374 @@
> +--- a/mtr-0.80/configure
> ++++ b/mtr-0.80/configure


I had a look at this patch and, sure it works. It would have been
preferable that it could have changed the configure.in file and then
run aclocal && autoreconf or similar. Instead of error out on missing
res_mkquery it could have set a config.h variable and then do
something like:

#ifndef HAVE_MK_QUERY
/* res_mkquery from dietlibc libcruft http://www.fefe.de/dietlibc/ */ 
...
#endif

and send that patch upstream.

(even better would probably to remove the entire dns.c and use c-ares
library)


That said, I think its good enough for Alpine anyways.
Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---