X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from localhost (3.203.202.84.customer.cdi.no [84.202.203.3])
	(using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: nc@alpinelinux.org)
	by mail.alpinelinux.org (Postfix) with ESMTPSA id 2CAB4DC0FF4;
	Wed, 21 Mar 2012 21:37:24 +0000 (UTC)
Date: Wed, 21 Mar 2012 22:37:36 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Nathan Angelacos <nangel@alpinelinux.org>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] snapshot for 120316
Message-ID: <20120321223736.30ff87e5@alpinelinux.org>
In-Reply-To: <4F69F6AA.7010006@alpinelinux.org>
References: <20120316182256.7217b654@alpinelinux.org>
	<4F69F6AA.7010006@alpinelinux.org>
X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 21 Mar 2012 08:41:30 -0700
Nathan Angelacos <nangel@alpinelinux.org> wrote:

> On 03/16/2012 10:22 AM, Natanael Copa wrote:
> > Hi,
> >
> > I have pushed a new alpine edge snapshot. It contains the support
> > for bridges, bonding and vlan (and vde2) configuring directly
> > in /etc/network/interfaces script.
> >
> <snip>
> >
> > Please test.
> 
> vlans and bridge tested - here's an example config:
> 
> ...
> auto vlan161
> iface vlan161 inet static
>          vlan-raw-device eth0
>          address 192.168.1.10
>          netmask 255.255.255.224
> 
> # Synthesized interfaces
> auto br0
> iface br0 inet dhcp
>          pre-up ifup vlan65
>          hostname wifi
>          bridge-ports vlan65
>          # vap0 is added by hostapd
>          post-down ifdown vlan65
> ....
> 
> 
> One small thing, in if-pre-up.d/vlan, line 19:
> 
>   *) [ -n "${IF_VLAN_ID}" -o -n "${IF_VLAN_RAW_DEVICE}" ]  || exit
> 0 ;;
> 
> 
> That doesn't set NAME1 like the others.  Even if it did,
> (NAME1=VLAN), ip still has problems finding the interface.
> 
> I was trying somthing insane like
> 
> iface foo inet dhcp
>     vlan-raw-device eth0
>     vlan-id 161
>     hostname foo

I don't think there are any vlan name type for creating a vlan
interfaces named 'foo'. (see vconfig man page. set_name_type
and  vlan_name_types in /usr/include/linux/if_vlan.h)
 
> Not sure that should be allowed - if not, perhaps change line 19 to 
> something like:
> 
> *) echo "Interface name is not valid for vlan" ; exit 1;;

actually, it is probably allowed to create vlan interfaces with any
name using iproute2. I removed the code that does that uses it though
since the busybox iproute does not support it. We could probably make
it work by detecting if its bb iproute or not. (i wanted ship something
working rather than aim for perfect and not ship at all)

Care to file a bug so i don't forget it?

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---