X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from localhost (unknown [187.40.245.230]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: nc@alpinelinux.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id F116DDC167D; Tue, 27 Mar 2012 15:11:32 +0000 (UTC) Date: Tue, 27 Mar 2012 17:11:40 +0200 From: Natanael Copa To: Nathan Angelacos Cc: Nathan Angelacos , alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [PATCH] New package - wifidog embedded captive portal Message-ID: <20120327171140.5b9c468c@alpinelinux.org> In-Reply-To: <4F70CA79.5080907@nothome.org> References: <1332712338-4483-1-git-send-email-nangel@alpinelinux.org> <20120326214351.349fe605@alpinelinux.org> <4F70CA79.5080907@nothome.org> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 26 Mar 2012 12:58:49 -0700 Nathan Angelacos wrote: > On 03/26/2012 12:43 PM, Natanael Copa wrote: > > On Sun, 25 Mar 2012 21:52:18 +0000 > > Nathan Angelacos wrote: > > > >> new file: testing/wifidog/APKBUILD > >> new file: testing/wifidog/wifidog.initd > >> --- > >> testing/wifidog/APKBUILD | 39 > >> +++++++++++++++++++++++++++++++++++++++ > >> testing/wifidog/wifidog.initd | 39 > >> +++++++++++++++++++++++++++++++++++++++ 2 files changed, 78 > >> insertions(+), 0 deletions(-) create mode 100644 > >> testing/wifidog/APKBUILD create mode 100755 > >> testing/wifidog/wifidog.initd > > > > I applied the patch. thanks! > > > warning: 5 lines add whitespace errors. > > Ok, I'll try to watch for that in the future. > > >> + rm -rf "$pkgdir"/usr/include || return 1 > > > > Why not craete a wifidog-dev package? > > Because the include file is not for wifidog at all. Its from of > http://www.hughes.com.au/products/libhttpd/ (something wifidog uses > internally.) > > I have no idea why they thought it was a good idea to include it in > the install process. They probably just cloned the sources. They also ship libhttp as a shared lib. I think we should either: * make wifidog link static to libhttp * put libhttp in separate apkbuild But we don't really need to anything of it til some other package start use libhttp and causes a file conflict. Thanks! -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---