Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Tue, 12 Jun 2012 07:39:03 +0300
From: Timo Teras <timo.teras@iki.fi>
To: jeremy@thomersonfamily.com
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] Re: [PATCH] Add DHCP to services.json
Message-ID: <20120612073903.21153926@vostro>
In-Reply-To: <CADVmKVAZ5ojFKor49TOA+c6Mk7FkW-PtroiGsQZ08iJ35DczFQ@mail.gmail.com>
References: <1338181266-5999-1-git-send-email-jeremy@thomersonfamily.com>
	<CADVmKVAZ5ojFKor49TOA+c6Mk7FkW-PtroiGsQZ08iJ35DczFQ@mail.gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi,

On Mon, 11 Jun 2012 22:28:34 -0500 Jeremy Thomerson
<jeremy@thomersonfamily.com> wrote:

> Anybody look at this yet?
> 
> On Mon, May 28, 2012 at 12:01 AM, Jeremy Thomerson <
> jeremy@thomersonfamily.com> wrote:
> 
> > ---
> >  json/services.json |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/json/services.json b/json/services.json
> > index ff1e82b..0d7d3ec 100644
> > --- a/json/services.json
> > +++ b/json/services.json
> > @@ -1,7 +1,8 @@
> >  {
> >   "service": {
> > -    "babel": { "proto": "tcp", "port": 6697 },
> > +    "babel": { "proto": "tcp", "port": 6697 },

Nit pick here, why is the line changed? Some whitespace change?

> >     "bgp": { "proto": "tcp", "port": 179 },
> > +    "dhcp": { "proto": "udp", "port": [ "67", "68" ] },
> >     "dns": [
> >       { "proto": "udp", "port": 53 },
> >       { "proto": "tcp", "port": 53 }
> > --

Yes - we need something like this. Though, I wonder if we want to
enable this by default for interfaces. Same goes with ICMPv6 since that
is a requirement for IPv6 things to work. We'll try to figure out this
soon.

Then again - in either case, we might want to add explicit rules, so
this should likely go in anway. I also wonder if we want to keep this
as-is, or also add the related icmpv6 codes to service 'dhcp' too.

- Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---