Date: Wed, 12 Sep 2012 22:49:03 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Mika Havela <mika.havela@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 1/2] testing/libzzip: New aport
Message-ID: <20120912224903.09142cb0@ncopa-laptop.res.nor.wtbts.net>
In-Reply-To: <1347478052-8352-1-git-send-email-mika.havela@gmail.com>
References: <1347478052-8352-1-git-send-email-mika.havela@gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit



On Wed, 12 Sep 2012 19:27:31 +0000
Mika Havela <mika.havela@gmail.com> wrote:

> A lightweight library that offers the ability to easily extract data
> from files archived in a single zip file
> http://zziplib.sourceforge.net ---
>  testing/libzzip/APKBUILD | 47
> +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47
> insertions(+) create mode 100644 testing/libzzip/APKBUILD

Nice! Thanks!
 
> diff --git a/testing/libzzip/APKBUILD b/testing/libzzip/APKBUILD
> new file mode 100644
> index 0000000..d446e61
> --- /dev/null
> +++ b/testing/libzzip/APKBUILD
> @@ -0,0 +1,47 @@
> +# Contributor: Mika Havela <mika.havela@gmail.com>
> +# Maintainer: Mika Havela <mika.havela@gmail.com>
> +pkgname=libzzip
> +_pkgbase=zziplib

How about calling this package as zziplib?

> +pkgver="0.13.62"
> +pkgrel=0
> +pkgdesc="A lightweight library that offers the ability to easily
> extract data from files archived in a single zip file"
> +url="http://zziplib.sourceforge.net" +arch="x86"
> +license="LGPL/MIT"
> +depends=""
> +depends_dev="perl-dev zlib-dev"
> +makedepends="$depends_dev python"
> +install=""
> +subpackages="$pkgname-dev $pkgname-doc"
> +source="http://downloads.sourceforge.net/${_pkgbase}/${_pkgbase}-${pkgver}.tar.bz2"
> +
> +_builddir="$srcdir/${_pkgbase}-${pkgver}"
> +prepare() {
> +	local i
> +	cd "$_builddir"
> +	for i in $source; do
> +		case $i in
> +		*.patch) msg $i; patch -p1 -i "$srcdir"/$i || return
> 1;;
> +		esac
> +	done
> +}
> +
> +build() {
> +	cd "$_builddir"
> +	export CC='gcc -m32'
> +	export CXX='g++ -m32'

Why? will this not break builds on x86_64?

> +	export PKG_CONFIG_PATH='/usr/lib/pkgconfig'
> +	export PYTHON='/usr/bin/python2'

Do we even have /usr/bin/python2 in Alpine Linux?

> +	
> +	./configure --prefix=/usr --libdir=/usr/lib
> +	make
> +}
> +
> +package() {
> +	cd "$_builddir"
> +	make DESTDIR="${pkgdir}" install || return 1
> +	rm -rf "${pkgdir}"/usr/{bin,include,share}

I don't think the above rm will work. The {bin,include,share} is
bashism and will probably not work on busybox ash.

And if it worked, it would have broken the -dev subpackage as you
probaly need the /usr/include.

> +	rm "${pkgdir}"/usr/lib/*.la || return 1
> +}
> +
> +md5sums="5fe874946390f939ee8f4abe9624b96c  zziplib-0.13.62.tar.bz2"

Do you mind if i create the package as zziplib and add a subpackage
called zziplib-utils where we move /usr/bin?

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---