X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from ncopa-desktop.nor.wtbts.net (3.203.202.84.customer.cdi.no [84.202.203.3])
	(using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: nc@alpinelinux.org)
	by mail.alpinelinux.org (Postfix) with ESMTPSA id D274CDC00BA;
	Wed, 31 Oct 2012 10:39:39 +0000 (UTC)
Date: Wed, 31 Oct 2012 11:39:37 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Oliver Loch <grimeton@gmx.net>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 1/2] Initial commit of Netatalk Version
 3.0.1
Message-ID: <20121031113937.6b3b9262@ncopa-desktop.nor.wtbts.net>
In-Reply-To: <1351455714-26496-2-git-send-email-grimeton@gmx.net>
References: <1351455714-26496-1-git-send-email-grimeton@gmx.net>
	<1351455714-26496-2-git-send-email-grimeton@gmx.net>
X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.13; x86_64-unknown-linux-gnu)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Thank you very much!

Some comments.

On Sun, 28 Oct 2012 21:21:53 +0100
Oliver Loch <grimeton@gmx.net> wrote:

> ---
>  main/netatalk/APKBUILD              | 80

We normally add new stuff to testing first, so we can let the build
servers build package and test that it is not completely broken before
we move it to main.

...
> +++ b/main/netatalk/APKBUILD
> @@ -0,0 +1,80 @@
> +# Contributor: Oliver Loch <grimeton@gmx.net>
> +# Maintainer:

And we would really only want maintained stuff in main.

...

> +package() {
> +	cd "$_builddir"
> +	make DESTDIR="$pkgdir" install || return 1
> +	[ ! -d "$pkgdir/usr/" ] && mkdir "$pkgdir/usr/"
> +	[ ! -d "$pkgdir/etc/netatalk/" ] && mkdir
> "$pkgdir/etc/netatalk/"

you can do mkdir -p "$pkgdir"/usr "$pkgdir"/etc/netatalk

but the make install should have done it really.

> +	[ -d "$pkgdir/sbin/" ] && mv "$pkgdir/sbin/"
> "$pkgdir/usr/sbin/"
> +	[ -d "$pkgdir/bin/" ] && mv "$pkgdir/bin/" "$pkgdir/usr/bin/"
> +	[ -d "$pkgdir/lib/" ] && mv "$pkgdir/lib/" "$pkgdir/usr/lib/"
> +	[ -f "$pkgdir/etc/afp.conf" ] && mv "$pkgdir/etc/afp.conf"
> "$pkgdir/etc/netatalk/afp.conf" +

Those should not be needed. If they are, the makefiles are broke and
should be patched. (and submitted upstream)

...

> diff --git a/main/netatalk/netatalk.pre-install
> b/main/netatalk/netatalk.pre-install new file mode 100644
> index 0000000..46079e0
> --- /dev/null
> +++ b/main/netatalk/netatalk.pre-install
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +
> +# add something which happends before install
> +

This file could be removed. It would generate an extra fork (=slow
down) during install for no reason.

Do you think you could fix up the mentioned issues and resend a single
new patch with the things fixed?

do something like:

# fix things and test that it builds
cp -r main/netatalk testing/netatalk
git add testing/netatalk
git commit -v

# as commit message you have something like:
testing/netatalk: new aport

<short descroption what it is>
<url>
# git send-email --to alpine-devel@lists.alpinelinux.org HEAD^


If you are familiar with git can ofcourse also do:
 git pull --rebase
 git mv main/netatalk testing/
 git commit --amend
 git rebase -i
# merge the commits into one and fix the commit message

and then resend it.

Thanks!


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---