Date: Wed, 21 Nov 2012 10:40:36 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Pablo Castorino <pcastorino@mendoza-conicet.gob.ar>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 1/2] ifplugd: new aport
Message-ID: <20121121104036.56a41f7b@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1353416120-12198-1-git-send-email-pcastorino@mendoza-conicet.gob.ar>
References: <1353416120-12198-1-git-send-email-pcastorino@mendoza-conicet.gob.ar>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 20 Nov 2012 09:55:19 -0300
Pablo Castorino <pcastorino@mendoza-conicet.gob.ar> wrote:

> ---
>  testing/ifplugd/APKBUILD      |   48

Applied. I also fixed mandir, added a -doc subpackage and removed
libdaemon depends as it gets autodetected by abuild.

> +++++++++++++++++++++++++++++++++++++++++
> testing/ifplugd/ifplugd.initd |   32 +++++++++++++++++++++++++++ 2
> files changed, 80 insertions(+) create mode 100644
> testing/ifplugd/APKBUILD create mode 100644
> testing/ifplugd/ifplugd.initd
> 
> diff --git a/testing/ifplugd/APKBUILD b/testing/ifplugd/APKBUILD
> new file mode 100644
> index 0000000..8a75dfd
> --- /dev/null
> +++ b/testing/ifplugd/APKBUILD
...

> +start() {
> +	checkconfig || return 1
> +
> +	ebegin "Starting ifplugd"
> +	sh /usr/sbin/ifplugd-helper start

I think the ifplugd-helper script, which appears to be a sysv/upstart
script, should be ported to a proper openrc runscript. In other words,
do what the helper script does in initd instead of just wrap it.

> +	result=$?
> +	eend $result
> +}

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---