X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from ncopa-desktop.alpinelinux.org (3.203.202.84.customer.cdi.no [84.202.203.3])
	(using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: nc@alpinelinux.org)
	by mail.alpinelinux.org (Postfix) with ESMTPSA id AC756DC00A5;
	Wed, 27 Feb 2013 10:43:30 +0000 (UTC)
Date: Wed, 27 Feb 2013 11:43:28 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8=D0=B9?= 'Rush'
 =?UTF-8?Q?=D0=9D=D0=B5=D0=BF=D0=BE=D0=BC=D0=BD=D1=8F=D1=89=D0=B8=D0=B9?=
 <rush.zlo@gmail.com>, alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] mkinitfs initramfs-init questions
Message-ID: <20130227114328.37822965@ncopa-desktop.alpinelinux.org>
In-Reply-To: <20130226222040.16f2a4a4@ncopa-laptop.res.nor.wtbts.net>
References: <CA+=xjkCj-ggSWtSUGrXVUiDNYAXw-V63z9d_=4Zscwg1Zg01qw@mail.gmail.com>
	<20130226214549.3e82b644@ncopa-laptop.res.nor.wtbts.net>
	<20130226222040.16f2a4a4@ncopa-laptop.res.nor.wtbts.net>
X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.15; x86_64-unknown-linux-gnu)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 26 Feb 2013 22:20:40 +0100
Natanael Copa <ncopa@alpinelinux.org> wrote:

> On Tue, 26 Feb 2013 21:45:49 +0100
> Natanael Copa <ncopa@alpinelinux.org> wrote:
>  
> > > 4. Code looks overcomplicated because there are
> > >   a) not many options to be parsed by initramfs-init
> > >   b) not all kernel options must be parsed by initramfs-init,
> > > unknown options must be skipped (and errors as in #2 will not be
> > > raised in the future)
> > 
> > Agree. We should only fish out the options we actually use and don't
> > bother about the rest.
> 
> How about this:
> diff --git a/initramfs-init.in b/initramfs-init.in
> index 6e1ebc1..60a0255 100755
> --- a/initramfs-init.in
> +++ b/initramfs-init.in
> @@ -283,22 +283,23 @@ echo "Alpine Init $VERSION"
>  # acpi_osi="!Windows 2006"
>  eval set -- `cat /proc/cmdline`
>  
> -while [ $# -gt 0 ]; do
> -	case "$1" in
> -		s|single|1)
> -			SINGLEMODE=yes ;;
> -		console=*)
> -			CONSOLE="$CONSOLE ${1#console=}";;
> -		*=*)    eval "KOPT_${1%%=*}='${1#*=}'" ;;
> -		no*)    eval "KOPT_$(echo ${1#no} | sed 's: :_:g')=no" ;;
> -		*)      eval "KOPT_$(echo $1 | sed 's: :_:g')=yes" ;;
> +for opt in "$@"; do
> +	case "$opt" in
> +	s|single|1)
> +		SINGLEMODE=yes ;;
> +	console=*)
> +		CONSOLE="$CONSOLE ${opt#console=}";;
> +	debug_init)
> +		set -x;;
> +	alpine_dev|autodetect|autoraid|chart|cryptroot|debug_init|dma|init_args|keep_apk_new|modules|ovl_dev|pkgs|quiet|root_size|root|usbdelay)
> +		case "$opt" in
> +		*=*)    eval "KOPT_${opt%%=*}='${opt#*=}'";;
> +		no*)    eval "KOPT_${opt#no}=no";;
> +		*)      eval "KOPT_$opt=yes";;
> +		esac
>  	esac
> -	shift
>  done

Will not work due to things like nochart noquiet. :-/

Anyone have better ideas?

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---