X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (3.203.202.84.customer.cdi.no [84.202.203.3]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: nc@alpinelinux.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id B8B79DC0138; Mon, 6 May 2013 09:21:49 +0000 (UTC) Date: Mon, 6 May 2013 11:21:46 +0200 From: Natanael Copa To: Nathan Angelacos Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [PATCH] main/libunistring/APKBUILD Message-ID: <20130506112146.1d806f77@ncopa-desktop.alpinelinux.org> In-Reply-To: <1367800260-6405-1-git-send-email-nangel@alpinelinux.org> References: <1367800260-6405-1-git-send-email-nangel@alpinelinux.org> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-unknown-linux-gnu) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 6 May 2013 00:31:00 +0000 Nathan Angelacos wrote: > New package for unicode string handling Applied thanks! A few nitpicks below... > --- > main/libunistring/APKBUILD | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 main/libunistring/APKBUILD > > diff --git a/main/libunistring/APKBUILD b/main/libunistring/APKBUILD > new file mode 100644 > index 0000000..48390ff > --- /dev/null > +++ b/main/libunistring/APKBUILD > @@ -0,0 +1,41 @@ > +# Contributor: > +# Maintainer: Nathan Angelacos > +pkgname=libunistring > +pkgver=0.9.3 > +pkgrel=0 > +pkgdesc="GNU Unicode string library" > +url="http://www.gnu.org/software/libunistring/" > +arch="all" > +license="LGPLv3+" > +depends="" > +depends_dev="libiconv-dev" Does libiconv-dev need to be installed to be able to compile/link against libunistring? If not, you could have depends_dev empty and add libiconv-dev to makedepends. (As it it is now libunistring-dev depends on libiconv-dev) > +makedepends="$depends_dev" > +install="" > +subpackages="$pkgname-dev $pkgname-doc" > +source="http://ftp.gnu.org/gnu/libunistring/$pkgname-$pkgver.tar.gz" ... > +md5sums="db8eca3b64163abadf8c40e5cecc261f libunistring-0.9.3.tar.gz" Looks like an old abuild was used. I think we want sha256 and sha512 sums too. -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---