X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from ncopa-desktop.alpinelinux.org (3.203.202.84.customer.cdi.no [84.202.203.3])
	(using SSLv3 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: nc@alpinelinux.org)
	by mail.alpinelinux.org (Postfix) with ESMTPSA id 7BE85DC0176;
	Mon,  6 May 2013 11:46:44 +0000 (UTC)
Date: Mon, 6 May 2013 13:46:41 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Mika Havela <mika.havela@gmail.com>, alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] main/iaxmodem: Create/modify init.d
 scripts iaxmodem can now be run using '/etc/init.d/iaxmodem start' iaxmodem
 is also being patched so it can handle '-P <pidfile>' option.
Message-ID: <20130506134641.44c153ea@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1367823175-19588-1-git-send-email-mika.havela@gmail.com>
References: <1367823175-19588-1-git-send-email-mika.havela@gmail.com>
X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-unknown-linux-gnu)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon,  6 May 2013 06:52:55 +0000
Mika Havela <mika.havela@gmail.com> wrote:

Thanks! I have some comments below.

> ---
>  main/iaxmodem/APKBUILD         |  54 ++++++++++++++----
>  main/iaxmodem/iaxmodem.c.patch | 126 +++++++++++++++++++++++++++++++++++++++++
>  main/iaxmodem/iaxmodem.confd   |   5 ++
>  main/iaxmodem/iaxmodem.initd   |  14 ++---
>  4 files changed, 179 insertions(+), 20 deletions(-)
>  create mode 100644 main/iaxmodem/iaxmodem.c.patch
> 
> diff --git a/main/iaxmodem/APKBUILD b/main/iaxmodem/APKBUILD
> index 650004c..d29f232 100644
> --- a/main/iaxmodem/APKBUILD
> +++ b/main/iaxmodem/APKBUILD
> @@ -1,38 +1,57 @@
>  # Contributor: Cameron Banta <cbanta@gmail.com>
> +# Contributor: Mika Havela <mika.havela@gmail.com>
>  # Maintainer: Cameron Banta <cbanta@gmail.com>
>  pkgname=iaxmodem
>  pkgver=1.2.0
> -pkgrel=4
> +pkgrel=5
>  pkgdesc="Softmodem for hylafax that connects to VOIP gateway with IAX"
>  url="http://iaxmodem.sourceforge.net/"
>  arch="all"
>  license="GPL"
> -depends=
> -makedepends="tiff-dev"
> -install=
> +depends=""
> +depends_dev="uclibc-dev"

You normally don't need uclibc-dev in the depends. abuild will pull it in via build-base. Also, adding uclibc-dev in there will break things for the glibc fork.

> +makedepends="$depends_dev tiff-dev"
> +install=""

...

> diff --git a/main/iaxmodem/iaxmodem.c.patch b/main/iaxmodem/iaxmodem.c.patch

You should run this patch with upstream.

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---