Date: Fri, 28 Jun 2013 11:13:33 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Dubiousjim <dubiousjim@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 01/15] cosmetic changes
Message-ID: <20130628111333.0723e0ce@ncopa-desktop.alpinelinux.org>
In-Reply-To: <7a986f63d724ba3626fbd6e0f75aaab32fecf884.1372361242.git.dubiousjim@gmail.com>
References: <cover.1372361242.git.dubiousjim@gmail.com>
	<7a986f63d724ba3626fbd6e0f75aaab32fecf884.1372361242.git.dubiousjim@gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 27 Jun 2013 15:28:46 -0400
Dubiousjim <dubiousjim@gmail.com> wrote:

> ---
>  src/add.c         |  5 +++--
>  src/apk.c         |  2 +-
>  src/apk_package.h |  2 +-
>  src/archive.c     |  2 +-
>  src/database.c    | 14 ++++++--------
>  src/dot.c         |  2 +-
>  src/fetch.c       |  2 +-
>  src/index.c       |  2 +-
>  src/info.c        |  4 ++--
>  src/lua-apk.c     |  2 +-
>  src/search.c      |  2 +-
>  src/ver.c         |  4 ++--
>  12 files changed, 21 insertions(+), 22 deletions(-)

Looks good to me. (a minor comment below)

acked-by: Natanael Copa <ncopa@alpinelinux.org>

> diff --git a/src/add.c b/src/add.c
> index 08fbf37..16e8dd1 100644
> --- a/src/add.c
> +++ b/src/add.c
> @@ -154,14 +154,15 @@ static struct apk_option add_options[] = {
>  	{ 'u',		"upgrade",	"Prefer to upgrade package" },
>  	{ 't',		"virtual",
>  	  "Instead of adding all the packages to 'world', create a new virtual "
> -	  "package with the listed dependencies and add that to 'world'. The "
> +	  "package with the listed dependencies and add that to 'world'; the "
>  	  "actions of the command are easily reverted by deleting the virtual "
>  	  "package", required_argument, "NAME" },
>  };
>  
>  static struct apk_applet apk_add = {
>  	.name = "add",
> -	.help = "Add/update PACKAGEs to main dependencies and install them",
> +	.help = "Add PACKAGEs to main dependencies and install (or upgrade) "
> +		"them, while ensuring that all dependencies are met",
>  	.arguments = "PACKAGE...",
>  	.open_flags = APK_OPENF_WRITE,
>  	.context_size = sizeof(struct add_ctx),

it could have been: (or upgrade, if -u is given)

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---