Date: Fri, 28 Jun 2013 11:19:03 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Dubiousjim <dubiousjim@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 03/15] clarify "apk version" usage
Message-ID: <20130628111903.04fbe4e7@ncopa-desktop.alpinelinux.org>
In-Reply-To: <8d44ebf8d8cb40a536d78d2a4f5871fa247bb60e.1372361242.git.dubiousjim@gmail.com>
References: <cover.1372361242.git.dubiousjim@gmail.com>
	<8d44ebf8d8cb40a536d78d2a4f5871fa247bb60e.1372361242.git.dubiousjim@gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 27 Jun 2013 15:28:48 -0400
Dubiousjim <dubiousjim@gmail.com> wrote:

> ---
>  src/ver.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ver.c b/src/ver.c
> index 99da504..fc7df5a 100644
> --- a/src/ver.c
> +++ b/src/ver.c
> @@ -183,8 +183,8 @@ static int ver_main(void *pctx, struct apk_database *db, struct apk_string_array
>  
>  static struct apk_option ver_options[] = {
>  	{ 'I', "indexes",	"Print description and versions of indexes" },
> -	{ 't', "test",		"Compare two given versions" },
> -	{ 'c', "check", 	"Check if the given version string is valid" },
> +	{ 't', "test",		"Compare two given versions, output '<' '=' or '>'" },
> +	{ 'c', "check", 	"Check the given version strings, output any that are invalid" },
>  	{ 'a', "all",		"Consider packages from all repository tags" },
>  	{ 'l', "limit",		"Limit output to packages with status matching one of LIMCHARs",
>  	  required_argument, "LIMCHARs" },

shouldn't it be a comma (,) in there?

...output '<', '=' or '>'

> @@ -192,7 +192,8 @@ static struct apk_option ver_options[] = {
>  
>  static struct apk_applet apk_ver = {
>  	.name = "version",
> -	.help = "Compare package versions",
> +	.help = "Compare package versions (in installed database vs. available) "
> +		"or do tests on literal version strings (with or without -rN suffixes)",
>  	.open_flags = APK_OPENF_READ,
>  	.context_size = sizeof(struct ver_ctx),
>  	.num_options = ARRAY_SIZE(ver_options),

Can we drop the "(with or without -rN suffixes)" part? it looks like -r -N options...

otherwise looks ok.

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---