X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by mail.alpinelinux.org (Postfix) with ESMTPS id 832A4DC0276
	for <alpine-devel@lists.alpinelinux.org>; Fri, 28 Jun 2013 10:03:10 +0000 (UTC)
Received: by mail-ee0-f41.google.com with SMTP id d17so942921eek.28
        for <alpine-devel@lists.alpinelinux.org>; Fri, 28 Jun 2013 03:03:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=sender:date:from:to:cc:subject:message-id:in-reply-to:references
         :x-mailer:mime-version:content-type:content-transfer-encoding;
        bh=rvOgM4DI8SxLFgf+kRQTRBS6ZwVDffKLEkWlpyfpEvA=;
        b=p2kSZLOD28wA/bD6ZibHABn3g/YACrXNCMHIdO6OTI02zm15dlyrcjQZH5qlYzB7K+
         5LhUTsGodWD2hQncyg+BRUuEm0R5uVlMaVLbJMagcS2xYFVr5Df8dmGfDksOXzYxjhJB
         zeH/8vc966deUS+00wSrkis5VUKdmLhLwfjYUZrGZ16/DZP0x0dE0Tob/pYe1bCIQs3z
         Oem1DO9Fi30WoIggGdHFBN+z5GHrOhtOhKZ9ZJn5tiKwygaEoVdzSW+qfxMhWcBlrMCH
         807hW/wd+rpbUKtKR7FxcBlE8JMSMH66+sXxAWFYmy0N753UDu4AMI5MKiRUa3ZsZM7m
         livw==
X-Received: by 10.15.45.5 with SMTP id a5mr13139483eew.7.1372413788819;
        Fri, 28 Jun 2013 03:03:08 -0700 (PDT)
Received: from vostro ([83.145.235.199])
        by mx.google.com with ESMTPSA id ci50sm9473516eeb.12.2013.06.28.03.03.08
        for <multiple recipients>
        (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
        Fri, 28 Jun 2013 03:03:08 -0700 (PDT)
Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Fri, 28 Jun 2013 13:03:19 +0300
From: Timo Teras <timo.teras@iki.fi>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: Dubiousjim <dubiousjim@gmail.com>, alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 06/15] move -U option to applets that use
 it
Message-ID: <20130628130319.3926fe1c@vostro>
In-Reply-To: <20130628113509.136ebe3c@ncopa-desktop.alpinelinux.org>
References: <cover.1372361242.git.dubiousjim@gmail.com>
	<59171458300c7aaaf33babda6cd5a8dc0601b90e.1372361242.git.dubiousjim@gmail.com>
	<20130628113509.136ebe3c@ncopa-desktop.alpinelinux.org>
X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.17; i686-pc-linux-gnu)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 28 Jun 2013 11:35:09 +0200
Natanael Copa <ncopa@alpinelinux.org> wrote:

> On Thu, 27 Jun 2013 15:28:51 -0400
> Dubiousjim <dubiousjim@gmail.com> wrote:
> 
> > ---
> >  src/add.c     | 4 ++++
> >  src/apk.c     | 4 ----
> >  src/dot.c     | 4 ++++
> >  src/fetch.c   | 4 ++++
> >  src/fix.c     | 4 ++++
> >  src/info.c    | 4 ++++
> >  src/search.c  | 4 ++++
> >  src/upgrade.c | 4 ++++
> >  src/ver.c     | 4 ++++
> >  9 files changed, 32 insertions(+), 4 deletions(-)
> 
> Since there are many applets using same option, I wonder if we could
> join them somehow?
> 
> It might not matter since I think the gcc optimizer will store only
> one copy of the identical string constants.

I think it should do this automatically. But I really don't like
duplicating the code how to handle each option in all the applets.

I do like the idea of pushing these options down the applets that
actually use them. So seems we need some sort of "option group" support.

- Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---