X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 87B85DC0091 for ; Fri, 28 Jun 2013 15:05:10 +0000 (UTC) Received: from compute5.internal (compute5.nyi.mail.srv.osa [10.202.2.45]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id B947320F24 for ; Fri, 28 Jun 2013 11:05:03 -0400 (EDT) Received: from frontend2.nyi.mail.srv.osa ([10.202.2.161]) by compute5.internal (MEProxy); Fri, 28 Jun 2013 11:05:03 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:content-type:in-reply-to; s=smtpout; bh=6FaLhfaVL6b78oqKMzomiDfimko=; b=dpwnGV2hgGAzbNJZAMDt1Y7GcbHX ns1Rt1MunP3gHu+BM3ipGRXdib/w+4H9BaSHTmjagMLNCoEZZhtOLYDYUKudbVp4 BLI2S5sS/1z/zgBICtEoUJTK7CCYV+Wna6ymwRCfUhDxP0f8LnX9R5tnaaL8fByq c6INSobf/CRrAAk= X-Sasl-enc: DSA0CvUrxNjU/sk51Lma6NVmq671Oxy8dEgEO4UOWIXY 1372431902 Received: from localhost (unknown [216.165.95.72]) by mail.messagingengine.com (Postfix) with ESMTPA id CCC3F680220 for ; Fri, 28 Jun 2013 11:05:02 -0400 (EDT) Date: Fri, 28 Jun 2013 11:05:02 -0400 From: Dubiousjim To: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [PATCH 7/8] main/syslinux: don't create backup when no changes Message-ID: <20130628150502.GA1712@zen.nyu.edu> Mail-Followup-To: alpine-devel@lists.alpinelinux.org References: <9f64bdebfb6a83b015fe0a1d7c08750926fb0ab1.1372318132.git.dubiousjim@gmail.com> <20130628164342.1b7d4e76@ncopa-desktop.alpinelinux.org> X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130628164342.1b7d4e76@ncopa-desktop.alpinelinux.org> User-Agent: Mutt/1.5.21 (2010-09-15) On Fri, Jun 28, 2013 at 04:43:42PM +0200, Natanael Copa wrote: > On Thu, 27 Jun 2013 03:32:20 -0400 > Dubiousjim wrote: > > > --- > > main/syslinux/update-extlinux | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/main/syslinux/update-extlinux b/main/syslinux/update-extlinux > > index 66bc0ed..a8b0474 100755 > > --- a/main/syslinux/update-extlinux > > +++ b/main/syslinux/update-extlinux > > @@ -169,18 +169,22 @@ if [ -f "/boot/reboot.c32" ]; then > > echo "" >> $conf.new > > fi > > > > +if diff -q $conf.new $conf >/dev/null 2>&1; then > > + everbose "Configuration unchanged." > > + rm $conf.new > > +fi > > maybe use 'cmp -s' instead of diff? Fine by me. If no one else weighs in... do you just want to apply what I sent and amend the commit to use "cmp -s"? Or would you rather I send a new one? -- Dubiousjim dubiousjim@gmail.com --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---