Date: Wed, 3 Jul 2013 10:09:10 -0400
From: Dubiousjim <dubiousjim@gmail.com>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 3/4] update-conf: accept long options
Message-ID: <20130703140910.GE1550@zen>
Mail-Followup-To: Natanael Copa <ncopa@alpinelinux.org>,
	alpine-devel@lists.alpinelinux.org
References: <cover.1372713126.git.dubiousjim@gmail.com>
 <6d0295ddc265976445cb2d46c6194db304e92386.1372713126.git.dubiousjim@gmail.com>
 <20130703153033.5230023e@ncopa-desktop.alpinelinux.org>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130703153033.5230023e@ncopa-desktop.alpinelinux.org>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jul 03, 2013 at 03:30:33PM +0200, Natanael Copa wrote:
> On Mon,  1 Jul 2013 17:14:16 -0400
> Dubiousjim <dubiousjim@gmail.com> wrote:

> > -while getopts "alih" opt ; do
> > -	case "$opt" in
> > -		a)	aflag="-a" ;;
> > -		i)	iflag="-i" ;;
> > -		l)	lflag="-l" ;;
> > -		h|*)	usage;;
> > -	esac	
> > +args=`getopt -o ailh --long all,initd,list,help -n "$PROGRAM" -- "$@"`
> 
> I don't think this is posix shell compatible.
> 
> We already use various extensions like 'local' and shell replace
> expansion ${var/search/replace} so we already depend on an extended shell.
> 
> I think this is ok for now, but we should be aware of that this is
> moving away from posix shell compat.
> 
> Is long options worth it?

I've got a bunch of patches for the abuild package too that I'm cleaning up,
including long options for many of the small scripts.

I'm pretty sure you're right that POSIX doesn't require any getopt shell
command or utility. So this is extra-POSIX. BusyBox (as we configure it)
provides getopt as an external utility, so in our case we do go beyond
Posix but we're not thereby requiring an extra-POSIX *shell*.

Perhaps Bash implements getopt as an internal shell command, I don't
remember.

> I also made a posix shell implementation for parsing options for lxc
> templates which we could use instead.

Where is that?

-- 
Dubiousjim
dubiousjim@gmail.com


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---