Date: Mon, 8 Jul 2013 15:09:56 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Dubiousjim <dubiousjim@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] patch and 2 questions for alpine-conf
 repo
Message-ID: <20130708150956.6750ab71@ncopa-desktop.alpinelinux.org>
In-Reply-To: <cover.1372998997.git.dubiousjim@gmail.com>
References: <cover.1372998997.git.dubiousjim@gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri,  5 Jul 2013 00:46:10 -0400
Dubiousjim <dubiousjim@gmail.com> wrote:

> Thanks for applying the alpine-conf patches I sent the other day, but this is still
> needed to clean up the VERSION reference. (Sorry for sending the bad patch in the first place here.)

No problem. We expect high quality, but not perfectionism.

Thanks for fixing it.

> Also:
> 
> Q1. Like abuild, I notice this Makefile also has a "dist" target. Might we still use that? If not should we purge it?

We purge it.

> Q2. There's also a funny extension target, for the extension ".sh.in.sh". Is that correct, or a typo?
> 
> The abuild repo's Makefile has:
> 
> 	.SUFFIXES:      .sh.in .in
> 	%.sh: %.sh.in
> 	        ${SED} ${SED_REPLACE} ${SED_EXTRA} $< > $@
> 	        ${CHMOD} +x $@
> 	
> 	%: %.in
> 	        ${SED} ${SED_REPLACE} ${SED_EXTRA} $< > $@
> 	        ${CHMOD} +x $@
> 
> which makes natural sense. Whereas alpine-conf's Makefile has:
> 
> 	.SUFFIXES:      .sh.in .in
> 	.sh.in.sh:
> 	        ${SED} ${SED_REPLACE} ${SED_EXTRA} $< > $@
> 	
> 	.in:
> 	        ${SED} ${SED_REPLACE} ${SED_EXTRA} $< > $@
> 
> On the face of it, those rules look screwy, but maybe there's some (overly?) clever
> Makefile-fu going on here that I haven't divined.

It is old fashioned suffix rules that are obsolete. We should use former.

http://www.gnu.org/software/make/manual/make.html#Suffix-Rules


> 
> 
> Dubiousjim (1):
>   update-conf: fix version
> 
>  update-conf.in | 2 ++
>  1 file changed, 2 insertions(+)
> 

applied that. thanks!


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---