Date: Fri, 12 Jul 2013 14:04:54 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Dubiousjim <dubiousjim@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 00/31] patch series for abuild repo
Message-ID: <20130712140454.4d83e502@ncopa-desktop.alpinelinux.org>
In-Reply-To: <cover.1372997335.git.dubiousjim@gmail.com>
References: <cover.1372997335.git.dubiousjim@gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri,  5 Jul 2013 00:21:09 -0400
Dubiousjim <dubiousjim@gmail.com> wrote:

> Sorry for so many patches. I tried hard to rebase them into natural-sized
> chunks for reviewing. I'll rebase them further if you like. But I thought it
> was time to hand them over to other eyes.
> 
> These hardly touch abuild itself, nor newapkbuild, buildrepo, or buildlab. I've
> got some notes for the first two of these, that I'll come back to another day.
> 
> Most of the changes here are internal.
> 
> The main externally-visible changes are: long options, some tweaked error messages,
> permitting environment variable overrides to settings from abuild.conf files, and
> hopefully some more robust behavior in places.

I pushed them all a fixed a few issues they introduced. I reverted one
abump change in the behaviour. I'd like it to not exit with error if
version is same because I sometimes re-run abump after fixing up issues
in apkbuild (as it git commits for me too with proper commit message)

Also tagged a new release.

Thanks!
> 
> 
> Dubiousjim (31):
>   remove unused files
>   abuild-sudo, abuild-tar: cosmetic changes
>   various: add descriptions, attribution, license
>   various: tweak opening comments, whitespace
>   abuild-keygen: refactor
>   abuild-sign: refactor
>   various: move conf-loading and i/o to functions
>   Makefile: add missing files to dist
>   Makefile: remove dist
>   various: use long options, rework usages
>   abuild_keygen: several tweaks
>   abuild-sign: reformat error output
>   abuild-sign: make vars local
>   abuild-sign: wrap cd in a subshell, use set -e
>   abuild-sign: fix a race condition
>   abump: move loop inside do_bump, refine locals
>   abump: introduce subshell, rc
>   abump: make abuild also clean
>   abump: tweak upgrade/cvelist
>   abump, functions: refactor (and verify) calculation of APKBUILD path
>   abump: refactor verification of APKBUILD
>   abump: verify APKBUILD's version
>   abump: verify that we're in git tree
>   apkgrel: --clean-git enhancements
>   apkgrel: show_plain, show_pretty
>   apkgrel: tweaks to loops, add quotes
>   apkgrel: handle missing pkgrel in do_add
>   various: s/echo/msg/, s/echo/error/, tweak error messages
>   apkgrel, functions: refactor calculation of APKBUILD's path
>   various: fancier readconfig, permit env overrides
>   functions: also honor .abuild file at gitbase
> 
>  APKBUILD-svn.proto |  46 --------
>  Makefile           |  14 +--
>  abuild-keygen.in   | 190 +++++++++++++++++----------------
>  abuild-sign.in     | 132 ++++++++++++-----------
>  abuild-sudo.c      |  13 ++-
>  abuild-tar.c       |   2 +-
>  abuild.in          |   4 +-
>  abump.in           | 155 +++++++++++++++++----------
>  alpine.mk          | 302 -----------------------------------------------------
>  alpine.packages    | 124 ----------------------
>  apkgrel.in         | 126 +++++++++++++++-------
>  checkapk.in        |  52 +++++----
>  functions.sh       |  34 ------
>  functions.sh.in    | 150 ++++++++++++++++++++++++++
>  mkinitram          |  88 ----------------
>  mkmodloop          |  37 -------
>  newapkbuild.in     |  60 +++++------
>  17 files changed, 585 insertions(+), 944 deletions(-)
>  delete mode 100644 APKBUILD-svn.proto
>  delete mode 100755 alpine.mk
>  delete mode 100644 alpine.packages
>  delete mode 100644 functions.sh
>  create mode 100644 functions.sh.in
>  delete mode 100644 mkinitram
>  delete mode 100644 mkmodloop
> 



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---