Date: Mon, 2 Sep 2013 10:25:45 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Sam Dodrill <shadow.h511@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/shadowircd: new aport
Message-ID: <20130902102545.56d16638@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1378109501-7544-1-git-send-email-shadow.h511@gmail.com>
References: <1378109501-7544-1-git-send-email-shadow.h511@gmail.com>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Thanks!

a few nitpicks below.

On Mon,  2 Sep 2013 01:11:41 -0700
Sam Dodrill <shadow.h511@gmail.com> wrote:

> Scalable IRC daemon with many useful features
> http://www.github.com/shadowircd/shadowircd
...
> +pkgname=shadowircd
> +pkgver=6.3.3
> +pkgrel=1

initial apkbuild should have pkgrel=0

> +arch="all"
> +license="GPL2"
> +pkgusers="ircd"                                                                

whitespace errors   ^^^ (whitespace at end of line)

> +depends=""
> +depends_dev="bison flex openssl-dev zlib-dev libtool"
> +makedepends="$depends_dev"

The depends_dev package holds the depends for the -dev package. I doubt
that bison, flex and libtool is needed to be able to use the
shadowirc-dev package.

...

> diff --git a/testing/shadowircd/shadowircd.pre-install b/testing/shadowircd/shadowircd.pre-install
> new file mode 100644
> index 0000000..e40f840
> --- /dev/null
> +++ b/testing/shadowircd/shadowircd.pre-install
> @@ -0,0 +1,3 @@
> +#!/bin/sh
> +adduser -h /var/run/shadowircd -s /bin/false -S -D ircd 2>/dev/null

we should use /sbin/nologin instead of /bin/false now as shell.

> +exit 0

I fixed the whitespace errors and applied as is otherwise.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---