Date: Fri, 15 Nov 2013 16:38:31 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: IT Offshore <developer@it-offshore.co.uk>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 4/5] Initial APKBUILD for libsodium into
 /testing
Message-ID: <20131115163831.287c7ee5@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1384077540-7914-5-git-send-email-developer@it-offshore.co.uk>
References: <1384077540-7914-1-git-send-email-developer@it-offshore.co.uk>
	<1384077540-7914-5-git-send-email-developer@it-offshore.co.uk>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 10 Nov 2013 09:58:59 +0000
IT Offshore <developer@it-offshore.co.uk> wrote:

> libsodium / libsodium-dev - dependency for dnscrypt-proxy
> 
> Revised complete patch which no longer runs ldconfig.
> ---
>  testing/libsodium/APKBUILD | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 testing/libsodium/APKBUILD
> 
> diff --git a/testing/libsodium/APKBUILD b/testing/libsodium/APKBUILD
> new file mode 100644
> index 0000000..1a41ca6
> --- /dev/null
> +++ b/testing/libsodium/APKBUILD
> @@ -0,0 +1,40 @@
> +# Contributor: IT Offshore <developer@it-offshore.co.uk>
> +# Maintainer:
> +pkgname=libsodium
> +pkgver=0.4.5
> +pkgrel=0
> +pkgdesc="P(ortable|ackageable) NaCl-based crypto library"
> +url="https://github.com/jedisct1/libsodium"
> +arch="all"
> +license="custom:ISC"
> +depends="libc"

depends=libs not needed. abuild handles elf dependencies automatically.

> +options="libtool"

I assume you did this for getting rid ot the *.la error. We should
remove the .la files instead.

> +install="$pkgname.post-install"

This file was missing.


> +subpackages="$pkgname-dev"
> +source="https://github.com/jedisct1/$pkgname/releases/download/$pkgver/$pkgname-$pkgver.tar.gz"
> +
> +_builddir="$srcdir"/$pkgname-$pkgver
> +
> +build() {
> +        cd "$_builddir"
> +	./configure \
> +                --build=$CBUILD \
> +                --host=$CHOST \
> +                --prefix=/usr \
> +                || return 1
> +        make || return 1
> +}
> +
> +check() {
> +  cd "$pkgname-$pkgver"
> +  make check
> +}

we don't really have infrastructure for make check, but maybe we will at
some point so i let this stay. (its pretty nice to be able to do 'abuild check')

I fixed the mentioned issues and applied. Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---