Date: Fri, 15 Nov 2013 16:47:32 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: IT Offshore <developer@it-offshore.co.uk>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH 3/5] Initial APKBUILD for FWSNORT into
 testing
Message-ID: <20131115164732.509fd0db@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1384077540-7914-4-git-send-email-developer@it-offshore.co.uk>
References: <1384077540-7914-1-git-send-email-developer@it-offshore.co.uk>
	<1384077540-7914-4-git-send-email-developer@it-offshore.co.uk>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 10 Nov 2013 09:58:58 +0000
IT Offshore <developer@it-offshore.co.uk> wrote:

> re-submitted complete patch for FWSNORT correcting:
> 
> periodic.daily - now updates the SNORT rules / PSAD signatures daily.
> 
> fwsnort.post-install - now just shows a message to update signatures manually
> (to avoid any problems with installations on tmpfs). Now uses the system terminal
> colours $STRONG $GREEN.

in this case i think an informal message is nice.
...

> +57afe59d948bd559e9728cee34bfd721  fwsnort.update

some checksum was wrong... I updated it

> diff --git a/testing/fwsnort/fwsnort.up b/testing/fwsnort/fwsnort.up
> new file mode 100644
> index 0000000..b750f59
> --- /dev/null
> +++ b/testing/fwsnort/fwsnort.up
> @@ -0,0 +1,5 @@
> +#!/bin/sh
> +
> +#splice fwsnort rules into iptables whenever the network comes up
> +/var/lib/fwsnort/fwsnort.sh
> +

It looks wrong to have a script in /var/lib...

I applied it as is otherwise, with the checksum fix and commit message change.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---