X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from mail-la0-f52.google.com (mail-la0-f52.google.com [209.85.215.52])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by mail.alpinelinux.org (Postfix) with ESMTPS id 7840EDC0244
	for <alpine-devel@lists.alpinelinux.org>; Sat, 23 Nov 2013 16:14:54 +0000 (UTC)
Received: by mail-la0-f52.google.com with SMTP id ev20so1747951lab.39
        for <alpine-devel@lists.alpinelinux.org>; Sat, 23 Nov 2013 08:14:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=sender:date:from:to:cc:subject:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=5VkBpexhobmRpWsSFhpNgb8WC2czbF0gpO4oKbOwxj0=;
        b=zBFtDcboI32KN2r6i/6aUGoZNrmhzDwRPZfbQT5Eh+PehXxlaXbgqcs5laV+WwyVIY
         C3hgiNB7m/BgRczFeI/BhDFbyg7720vAiGTbAYjiqvN9EP7zQi2VSEYwOM/xFgziBN+L
         XWKJm8vaHwoDpxZvO3jmK9yoFW5UvebtpecqeNwcJa2FO2Lpgl2CrVh3qnDzzc+2T5bD
         Os8y5Q+uZxPdon86jkK9tstt2+DlOr7yW5AUhA9xd4Fy8E+7etBOcmV1KvAXxNGw1jLA
         SYJejvyc3F1UpFsxqPKvNgPpzxWeq+QyHk58RgdHum/xFigBrvS+oRLLvE4SzNNy1I9f
         2U/Q==
X-Received: by 10.152.26.131 with SMTP id l3mr1660089lag.29.1385222860099;
        Sat, 23 Nov 2013 08:07:40 -0800 (PST)
Received: from vostro ([83.145.235.194])
        by mx.google.com with ESMTPSA id mq10sm29702962lbb.12.2013.11.23.08.07.39
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Sat, 23 Nov 2013 08:07:40 -0800 (PST)
Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Sat, 23 Nov 2013 18:07:35 +0200
From: Timo Teras <timo.teras@iki.fi>
To: "Leslie P. Polzer | PORT ZERO" <polzer@port-zero.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] main/gcc: fix Ada -fno-stack-check handling
Message-ID: <20131123180735.6b700fdf@vostro>
In-Reply-To: <5290AD0F.2010203@port-zero.com>
References: <5290AD0F.2010203@port-zero.com>
X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; i486-alpine-linux-uclibc)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 23 Nov 2013 14:26:39 +0100
"Leslie P. Polzer | PORT ZERO" <polzer@port-zero.com> wrote:

> the old hack for this was probably too hacky; at least it
> no longer worked for me when cross-compiling to armhf-musl.
> Attached changeset replaces it with a cleaner approach that
> works.

>  main/gcc/APKBUILD | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> @@ -228,10 +228,7 @@ prepare() {
>  	# fix ada bootstrap
>  	# piepatches adds -fstack-check to spec which breaks ada
> bootstrap # TODO: upstream this to piepatches
> -	sed -i -e 's/stage1_cflags="$stage1_cflags
> -fno-stack-protector"/stage1_cflags="$stage1_cflags
> -fno-stack-protector -fno-stack-check"/g' \
> -		configure
> -	sed -i -e 's/^ESP_NOSSP_CFLAGS =
> -fno-stack-protector$/ESP_NOSSP_CFLAGS = -fno-stack-protector
> -fno-stack-check/g' \
> -		Makefile.in
> +	export ADA_CFLAGS='-fno-stack-check'
>  
>  	# genautomata crashes with a "Bus Error" when compiled with
> PIC # mostly affecting cross-builds as on native build bootstrapping

If you set environment vars, it should be in build() or in the global
block. Setting those in prepare() only breaks "abuild build".

But if a full bootstrap works otherwise, this probably is a good idea.

Thanks,
 Timo


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---