Date: Wed, 5 Mar 2014 10:11:38 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Kozak Ivan <kozak-iv@yandex.ru>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/nut: new aport
Message-ID: <20140305101138.006ffb75@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1393766380-18447-1-git-send-email-kozak-iv@yandex.ru>
References: <1393766380-18447-1-git-send-email-kozak-iv@yandex.ru>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun,  2 Mar 2014 17:19:40 +0400
Kozak Ivan <kozak-iv@yandex.ru> wrote:


> +# bcmxcp.patch - sorry no bcmxc and no bcmxcp_usb (get errors about undefined reference to `ldexp')

I fixed it and pushed a fix to aports.

> diff --git a/testing/nut/bcmxcp.patch b/testing/nut/bcmxcp.patch
> new file mode 100644
> index 0000000..644d9b7
> --- /dev/null
> +++ b/testing/nut/bcmxcp.patch
> @@ -0,0 +1,178 @@
> +--- Makefile.in
> ++++ src/nut-2.7.1/drivers/Makefile.in

A comment about the way this was 'resolved'. We normally try avoid
patching the Makefile.in since it is generated from Makefile.am. The
drawback with patching Makefile.am is that then we need re-run the
autotools (aclocal, autoconf automake etc) and that might introduce new
issues. The biggest benefit though is that the pach can normally be
submitted upstream.

Would you be able to submit a bugreport upstream (to nut developers)
and give them the patch i made:
http://git.alpinelinux.org/cgit/aports/tree/testing/nut/libm.patch

Basically when using ldexp you should link against libm (even the
manpage[1] says:

  Link with -lm.

Thanks!

-nc

[1] http://man7.org/linux/man-pages/man3/ldexp.3.html


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---