Date: Wed, 12 Mar 2014 19:13:48 +0000
From: Natanael Copa <ncopa@alpinelinux.org>
To: Stuart Cardall <developer@it-offshore.co.uk>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] /testing/openvswitch - version bump to
 2.01 + revised init scripts
Message-ID: <20140312191348.08adf429@ncopa-laptop>
In-Reply-To: <1394645810-19848-1-git-send-email-developer@it-offshore.co.uk>
References: <1394645810-19848-1-git-send-email-developer@it-offshore.co.uk>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I applied it and cleaned up the patch handling a bit and added a patch
for musl building.

I think the below needs be done differently though.

On Wed, 12 Mar 2014 17:36:50 +0000
Stuart Cardall <developer@it-offshore.co.uk> wrote:

>  db="/etc/openvswitch/conf.db"
>  if [ -e "$db" ]; then
> -	echo "Trying schema migration for $db..."
> -	ovsdb-tool convert "$db" "/usr/share/openvswitch/vswitch.ovsschema"
> +        print_red "\nStopping OVS Database\n"; rc-service ovsdb-server stop
> +        print_green "\nTrying schema migration for $db..."
> +        ovsdb-tool convert "$db" "/usr/share/openvswitch/vswitch.ovsschema"
> +        print_green "\nStarting OVS Database\n"; rc-service ovsdb-server start
>  else
> -	echo "Creating new Open vSwitch database $db..."
> -	ovsdb-tool create "$db" "/usr/share/openvswitch/vswitch.ovsschema"
> +        print_green "\nCreating new Open vSwitch database $db...\n"
> +        ovsdb-tool create "$db" "/usr/share/openvswitch/vswitch.ovsschema"
>  fi
>  
> +

What will happen if you have a conf.db, but it breaks your networking
so you stop the service. Then you upgrade. The post install/upgrade
will start it even if that was not the intention.

We don't start and stop services from install/upgrade/deinstall scripts.

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---