X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from dal-a2.localdomain (unknown [74.117.189.115]) by mail.alpinelinux.org (Postfix) with ESMTP id 2A3EEDC00F1 for ; Mon, 14 Apr 2014 06:26:52 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (3.203.202.84.customer.cdi.no [84.202.203.3]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: ncopa@tanael.org) by dal-a2.localdomain (Postfix) with ESMTPSA id 67275BC2DBC; Mon, 14 Apr 2014 06:26:51 +0000 (UTC) Date: Mon, 14 Apr 2014 06:26:47 +0000 From: Natanael Copa To: Der Tiger Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [PATCH] Updated freeswitch.initd to include missing path switches. Message-ID: <20140414062647.6308262e@ncopa-desktop.alpinelinux.org> In-Reply-To: <534A6B89.7000503@arcor.de> References: <1397371981-3308-1-git-send-email-tbooth@hindbra.in> <534A3DA7.6090609@arcor.de> <20140413075957.497c6499@ncopa-desktop.alpinelinux.org> <534A6B89.7000503@arcor.de> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 13 Apr 2014 12:48:41 +0200 Der Tiger wrote: > Natanael, > > > On 2014-04-13 09:59, Natanael Copa wrote: > > On Sun, 13 Apr 2014 09:32:55 +0200 > > Der Tiger wrote: > > > >> In order to make those switches adjustable by the user, I suggest to set > >> them in /etc/conf.d/freeswitch utilizing the ${OPTS} variable in the > >> init.d script rather than make them hard-coded in /etc/init.d/freeswitch > >> itself, because some folks my want to store recordings on a different > >> drive or use their own set of grammar and voice files. > > Yes, and it will break things for those who actually have things stored > > other location. > I don't see why pre-setting ${OPTS} in /etc/conf.d/freeswitch would > break anything for anyone. Anyway, introducing separate variables for > each switch, as you suggested, is certainly the better way to go. Sorry, I was unclear. What I meant was that hardcoding the paths in init.d will not only prevent people to store things in other location if they want. It will break things for those who already does it. Relying on $OPTS only will not break that, but otoh it will not solve the problem Tobie wants to solve either: a working default config. -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---