X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from dal-a2.localdomain (unknown [74.117.189.115]) by mail.alpinelinux.org (Postfix) with ESMTP id B8F7FDC009B for ; Mon, 19 May 2014 14:25:40 +0000 (UTC) Received: from ncopa-desktop.alpinelinux.org (3.203.202.84.customer.cdi.no [84.202.203.3]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: ncopa@tanael.org) by dal-a2.localdomain (Postfix) with ESMTPSA id ECD88BC11E1; Mon, 19 May 2014 14:25:39 +0000 (UTC) Date: Mon, 19 May 2014 16:25:36 +0200 From: Natanael Copa To: stef Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] initial commit of i3-wm apk Message-ID: <20140519162536.0d0935c5@ncopa-desktop.alpinelinux.org> In-Reply-To: <20140515203158.GB6834@ctrlc.hu> References: <20140515203158.GB6834@ctrlc.hu> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 15 May 2014 22:31:58 +0200 stef wrote: > +@@ -136,6 +136,7 @@ > + LIBSN_LIBS := $(call ldflags_for_lib, libstartup-notification-1.0,startup-notification-1) > + > + # Pango > ++PANGO_CFLAGS := $(call cflags_for_lib, pango) > + PANGO_CFLAGS := $(call cflags_for_lib, cairo) > + PANGO_CFLAGS += $(call cflags_for_lib, pangocairo) > + I3_CPPFLAGS += -DPANGO_SUPPORT=1 This looks wrong. it looks like it loses the cairo part. Shouldn't the pango cflags be appended instead? PANGO_CFLAGS := $(call cflags_for_lib, cairo) PANGO_CFLAGS += $(call cflags_for_lib, pangocairo) PANGO_CFLAGS += $(call cflags_for_lib, pango) I applied anyways as is since it built. Thanks! -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---