X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from ncopa-desktop.alpinelinux.org (3.203.202.84.customer.cdi.no [84.202.203.3])
	(using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: n@tanael.org)
	by mail.alpinelinux.org (Postfix) with ESMTPSA id 1E5D3DC0169;
	Mon, 30 Jun 2014 06:55:59 +0000 (UTC)
Date: Mon, 30 Jun 2014 08:55:56 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Isaac Dunham <ibid.ag@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] Add "-s" short option for "--simulate"
Message-ID: <20140630085556.297136e7@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1404009591-1984-1-git-send-email-ibid.ag@gmail.com>
References: <1404009591-1984-1-git-send-email-ibid.ag@gmail.com>
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-alpine-linux-musl)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 28 Jun 2014 19:39:51 -0700
Isaac Dunham <ibid.ag@gmail.com> wrote:

> Typing the long option gets old.
> ---
>  src/apk.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Have you checked that it does not break apk info -s <package>? (for displaying size usage)

-nc

> 
> diff --git a/src/apk.c b/src/apk.c
> index 970bbb1..8e3ae7c 100644
> --- a/src/apk.c
> +++ b/src/apk.c
> @@ -50,6 +50,8 @@ static struct apk_option generic_options[] = {
>  	{ 'V', "version",	"Print program version and exit" },
>  	{ 'f', "force",		"Do what was asked even if it looks dangerous" },
>  	{ 'U', "update-cache",	"Update the repository cache" },
> +	{ 's', "simulate",	"Show what would be done without actually "
> +				"doing it" },
>  	{ 0x101, "progress",	"Show a progress bar" },
>  	{ 0x10f, "progress-fd",	"Write progress to fd", required_argument, "FD" },
>  	{ 0x110, "no-progress",	"Disable progress bar even for TTYs" },
> @@ -59,8 +61,6 @@ static struct apk_option generic_options[] = {
>  				"package removal" },
>  	{ 0x103, "allow-untrusted", "Blindly install packages with untrusted "
>  				"signatures or no signature at all" },
> -	{ 0x104, "simulate",	"Show what would be done without actually "
> -				"doing it" },
>  	{ 0x105, "wait",	"Wait for TIME seconds to get an exclusive "
>  				"repository lock before failing",
>  				required_argument, "TIME" },
> @@ -409,6 +409,9 @@ int main(int argc, char **argv)
>  		case 'U':
>  			apk_flags |= APK_UPDATE_CACHE;
>  			break;
> +		case 's':
> +			apk_flags |= APK_SIMULATE;
> +			break;
>  		case 0x101:
>  			apk_flags |= APK_PROGRESS;
>  			break;
> @@ -424,9 +427,6 @@ int main(int argc, char **argv)
>  		case 0x103:
>  			apk_flags |= APK_ALLOW_UNTRUSTED;
>  			break;
> -		case 0x104:
> -			apk_flags |= APK_SIMULATE;
> -			break;
>  		case 0x106:
>  			apk_flags |= APK_PURGE;
>  			break;



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---