Date: Tue, 15 Jul 2014 16:28:18 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Isaac Dunham <ibid.ag@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/sword: add new package
Message-ID: <20140715162818.0f5adca9@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1405457044-3186-1-git-send-email-ibid.ag@gmail.com>
References: <1405457044-3186-1-git-send-email-ibid.ag@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 15 Jul 2014 13:44:04 -0700
Isaac Dunham <ibid.ag@gmail.com> wrote:

> Sword is a library for free Bible software.
> It can also be used for other books.
...

> +++ b/testing/sword/01-corediatheke.patch
> @@ -0,0 +1,18 @@
> +diff --git a/utilities/diatheke/corediatheke.cpp b/utilities/diatheke/corediatheke.cpp
> +index 6e05e7c..c2b6efb 100644
> +--- a/utilities/diatheke/corediatheke.cpp
> ++++ b/utilities/diatheke/corediatheke.cpp
> +@@ -454,7 +454,6 @@ void doquery(unsigned long maxverses = -1, unsigned char outputformat = FMT_PLAI
> + 						if (font) { *output << "style=\"font:\""  << font << ";\" " ;}
> + 						if (strcmp(modlocale,locale) !=0 ) { *output << "lang=\"" << modlocale << "\"";}
> + 						*output << ">";
> +-					}
> + 				}	
> + 
> + 				if (font && (outputformat == FMT_HTML || outputformat == FMT_HTMLHREF || outputformat == FMT_XHTML || outputformat == FMT_THML || outputformat == FMT_CGI)) {
> +@@ -498,4 +497,4 @@ void doquery(unsigned long maxverses = -1, unsigned char outputformat = FMT_PLAI
> + 		}
> + 
> + 	}
> +-
> ++}

I saw your work with upstream to get this fixed. What I find
interesting is that they didn't catch an error like this upstream. Why
didn't the problem show up on glibc?

musl again causes hidden bugs bubble up to the surface.

Good job!

Applied. Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---