X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by mail.alpinelinux.org (Postfix) with ESMTPS id 6619FDC0265
	for <alpine-devel@lists.alpinelinux.org>; Tue, 15 Jul 2014 18:16:51 +0000 (UTC)
Received: by mail-pa0-f50.google.com with SMTP id et14so2269310pad.37
        for <alpine-devel@lists.alpinelinux.org>; Tue, 15 Jul 2014 11:16:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:subject:message-id:mime-version:content-type
         :content-disposition:user-agent;
        bh=f8z5fi9yEoyaaiDlWC8M8CLs+Wq8aKjVC2uBAXRXoqY=;
        b=w/xlQ56Z9+Eo8QiDnltvl07NgN7YCV4ez7aNdxuaBSRjyH6DcwPxDoBUZ1rgQ/qHXV
         fir9EP8FoGqKdSIGHaaf8SnFJWgdgOOwAMDC5mPiH4vj39CjwBO3dnDI5mLBFqa3C4p0
         D/9mo9U1FbHp0GbKenjKqSw7ezXRg/Iy7ujL4cBV423Espsic/+C3yfAcEIwWjS6drrP
         spKRt1o2l/8JM3BTZAhbDK19a8EGg+yjh0D9NTj1GF3BAveWcKB9PrLWBMSMXC8tHz67
         h6YtOUz2fNZ5q8LZf4QgcXHj1LI6u6tMcNZNm4dFo+Yg+ByENBhTge1vCkmhL1WiDA0f
         Blkw==
X-Received: by 10.68.231.7 with SMTP id tc7mr24654110pbc.32.1405448210100;
        Tue, 15 Jul 2014 11:16:50 -0700 (PDT)
Received: from newbook ([50.0.229.120])
        by mx.google.com with ESMTPSA id kg1sm4600418pbc.22.2014.07.15.11.16.49
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Tue, 15 Jul 2014 11:16:49 -0700 (PDT)
Date: Tue, 15 Jul 2014 18:16:47 -0700
From: Isaac Dunham <ibid.ag@gmail.com>
To: musl@lists.openwall.com, alpine-devel@lists.alpinelinux.org
Subject: [alpine-devel] what should be done with SA_INTERRUPT? (gpm 1.20.7)
Message-ID: <20140716011646.GA1179@newbook>
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.23 (2014-03-12)

On alpine, gpm 1.20.7 doesn't build completely, so I've been poking at it.
There were numerous cases of sys/select.h being omitted, but the biggest
issue I've hit so far is the use of SA_INTERRUPT in a call to sigaction();
the purpose is to break out of select() without it getting restarted.
musl does not define or support SA_INTERRUPT, as far as I can tell (I
seem to recall that musl forces SA_RESTART).

This is in src/prog/gpm-root.y, which is the source for the "gpm-root"
utility.

Any idea what to do about this?
I could build gpm without it, but (a) I'd like to see the whole mess
build, and (b) I'm not sure how to tell make that it can skip gpm-root.

As a temporary fix, I'm using this patch:
-#if defined(__GLIBC__)
-   __sigemptyset(&childaction.sa_mask);
-#else /* __GLIBC__ */
-   childaction.sa_mask=0;
-#endif /* __GLIBC__ */
+   sigemptyset(&childaction.sa_mask);
+#ifdef SA_INTERRUPT
    childaction.sa_flags=SA_INTERRUPT; /* need to break the select() call */
+#endif


Thanks,
Isaac Dunham



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---