Date: Mon, 25 Aug 2014 09:02:28 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Peter Bui <pnutzh4x0r@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/ncmpc: new aport
Message-ID: <20140825090228.0c5127a5@ncopa-desktop.alpinelinux.org>
In-Reply-To: <1408771490-19120-1-git-send-email-pnutzh4x0r@gmail.com>
References: <1408771490-19120-1-git-send-email-pnutzh4x0r@gmail.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi,

Thanks for your contribution!

On Sat, 23 Aug 2014 00:24:50 -0500
Peter Bui <pnutzh4x0r@gmail.com> wrote:

> http://www.musicpd.org/clients/ncmpc/
> Fully featured MPD client using ncurses
> ---
>  testing/ncmpc/APKBUILD | 39 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 testing/ncmpc/APKBUILD
> 
> diff --git a/testing/ncmpc/APKBUILD b/testing/ncmpc/APKBUILD
> new file mode 100644
> index 0000000..9f7bd3b
> --- /dev/null
> +++ b/testing/ncmpc/APKBUILD
> @@ -0,0 +1,39 @@
> +# Contributor: Peter Bui <pnutzh4x0r@gmail.com>
> +# Maintainer:
> +pkgname=ncmpc
> +pkgver=0.24
> +pkgrel=0
> +pkgdesc="Fully featured MPD client using ncurses"
> +url="http://www.musicpd.org/clients/ncmpc/"
> +arch="all"
> +license="GPL2"
> +depends="ncurses glib libmpdclient"

you don't need add the above depends since abuild will normally
autodetect those. It will run scanelf for find the shared object (SO)
depends and find that the binary is linked to libncursesw.so.5 and
libglib-2.0.so.0 and will add the dependencies 'so:libncursesw.so.5'
'so:libglib-2.0.so.0'.

The ncurses package has a provides = so:libncursesw.so.5 so it will be
pulled in as dependency.

If we split the ncurses package in future, let for example say that we
move the libncursesw* files to a subpackage called ncurses-widec-libs,
then will we not need rebuild all packages that has depends="ncurses",
becuase we do depends=so:libncursesw.so.5 and apk will self figure out
which package that provides it.

I removed the depends and applied.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---