X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from mail-la0-f50.google.com (mail-la0-f50.google.com [209.85.215.50]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 097C2DC0110 for ; Tue, 2 Sep 2014 05:20:55 +0000 (UTC) Received: by mail-la0-f50.google.com with SMTP id mc6so7079118lab.37 for ; Mon, 01 Sep 2014 22:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=RAL9vDQGWR7cw3IJigHA2myknWodfFhrsb5ygcCZM28=; b=IEYXaB5Jl7TpRQ0P4jWP/R48LjV/2aQapMYgXyW9XTR2H66OencsBhO5FT321DogXq xZGMY7NE+3VppPWpKC4F2V+zn3w27fOzqyyY+p5wYbagTCkH/JbQ26a127PHb12BKgRk kU8LI8mFYblfP9FT8MoUeWVWm+AhhiqU0FYh5wor5Qy0MJFSs/12ZSSyGIMYZDgnCE3V O2+Ku93pLMwpTwAckLmfsvJV4Hp0GNowmASXH5+pUQ9mpEa3U1CO0oLvdo5mIA2KnfJz AICJxT4RIHcuddHmPKP9pb1UTmAxHmugSp2yDdX6Hi810GnL7K6Gr/xpRmLjdqGJBBZR w/zg== X-Received: by 10.112.235.199 with SMTP id uo7mr31084918lbc.50.1409635251655; Mon, 01 Sep 2014 22:20:51 -0700 (PDT) Received: from vostro ([2001:1bc8:101:f402:21a:9fff:fe0c:4022]) by mx.google.com with ESMTPSA id vl4sm3975281lbb.36.2014.09.01.22.20.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Sep 2014 22:20:51 -0700 (PDT) Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= Date: Tue, 2 Sep 2014 08:20:34 +0300 From: Timo Teras To: Johannes Matheis Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [PATCH] main/openssh: curve25519pad patch added Message-ID: <20140902082034.0b8bffb4@vostro> In-Reply-To: <1409587469-turnsole-84454@jmt.gr> References: <1409587469-turnsole-84454@jmt.gr> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 01 Sep 2014 16:05:55 +0000 Johannes Matheis wrote: > https://lists.mindrot.org/pipermail/openssh-unix-dev/2014-April/032494.ht= ml: > > bad bignum encoding for curve25519-sha256 at libssh.org > >[=E2=80=A6] > > So I screwed up when writing the support for the curve25519 KEX > > method that doesn't depend on OpenSSL's BIGNUM type - a bug in my > > code left leading zero bytes where they should have been skipped. > > The impact of this is that OpenSSH 6.5 and 6.6 will fail during key > > exchange with a peer that implements curve25519-sha256 at > > libssh.org properly about 0.2% of the time (one in every 512ish > > connections). The mailing list archives seem to have auto-converted all '@' symbols to string ' at ' including the patch's string literals. The patch you have attached is mangled and incorrect. Care to resend with pristine diff generated from upstream version control system? Thanks, Timo --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---