Date: Wed, 8 Oct 2014 12:02:45 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: Johannes Matheis <jomat+alpinebuild@jmt.gr>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/mumble: new aport
Message-ID: <20141008120245.53085dc7@ncopa-desktop.alpinelinux.org>
In-Reply-To: <20141002105628.9755.64731@leto.j.dn42>
References: <20141002105628.9755.64731@leto.j.dn42>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

The updated patch you sent me built. I have some comments on the
install scripts though. see below.

On Thu, 2 Oct 2014 10:52:55 +0000
Johannes Matheis <jomat+alpinebuild@jmt.gr> wrote:

> http://mumble.sourceforge.net/
> Mumble is an open source, low-latency, high quality voice chat software primarily intended for use while gaming
...

> diff --git a/testing/mumble/murmur.initd b/testing/mumble/murmur.initd
> new file mode 100644
> index 0000000..154db89
> --- /dev/null
> +++ b/testing/mumble/murmur.initd
> @@ -0,0 +1,13 @@
> +#!/sbin/runscript
> +
> +depends() {
> +   needs localmount
> +}
> +
> +description="Mumble VoIP Server"
> +command="/usr/bin/murmurd"
> +command_args="-ini /etc/murmur.ini"
> +pidfile="/var/run/murmur/murmur.pid"
> +
> +# uses the openrc templates for start()/stop()
> +
> diff --git a/testing/mumble/murmur.post-deinstall b/testing/mumble/murmur.post-deinstall
> new file mode 100755
> index 0000000..4088787
> --- /dev/null
> +++ b/testing/mumble/murmur.post-deinstall
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +delgroup murmur
> +deluser murmur
> +exit 0

We normally don't delete users on apk del.
Maybe we should start do so?


> diff --git a/testing/mumble/murmur.post-install b/testing/mumble/murmur.post-install
> new file mode 100755
> index 0000000..5098307
> --- /dev/null
> +++ b/testing/mumble/murmur.post-install
> @@ -0,0 +1,6 @@
> +#!/bin/sh
> +chown murmur /var/run/murmur/
> +chgrp murmur /var/run/murmur/

this should be done with:

start_pre() {
	checkpath --owner murmur:murmur --directory /var/run/murmur
}

in init.d script. /var/run might be mounted tmpfs after bootup so
anything under there must be created run time.

> +chown murmur /var/lib/murmur/
> +chgrp murmur /var/lib/murmur/

the dir permissions should be set in the apk. To do that you add:

pkgusers="murmur"
pkggroups="murmur"

in the apk build and in package() you do:

	chown murmur "$pkgdir"/var/lib/murmur/
	chgrp murmur "$pkgdir"/var/lib/murmur/

abuild should have given you warning about setting permissions from
post-install.

> +exit 0

> diff --git a/testing/mumble/murmur.pre-install b/testing/mumble/murmur.pre-install
> new file mode 100755
> index 0000000..cb0e0eb
> --- /dev/null
> +++ b/testing/mumble/murmur.pre-install
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +addgroup -S murmur
> +adduser -S -h /var/lib/murmur -s /sbin/nologin -G murmur -g "Mumble daemon" -H -D murmur
> +exit 0



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---