X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 9F96DDC0846; Thu, 16 Oct 2014 14:56:55 +0000 (UTC) Date: Thu, 16 Oct 2014 16:56:51 +0200 From: Natanael Copa To: k0r10n Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [PATCH] Added -fPIC flag to fix pci_malloc relocation Message-ID: <20141016165651.7a985bde@ncopa-desktop.alpinelinux.org> In-Reply-To: <1413299250-8994-1-git-send-email-k0r10n.dev@gmail.com> References: <1413299250-8994-1-git-send-email-k0r10n.dev@gmail.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 14 Oct 2014 19:07:30 +0400 k0r10n wrote: > --- > main/pciutils/APKBUILD | 8 ++++++-- > main/pciutils/fix-linking-pci-malloc-Makefile.patch | 11 +++++++++++ > 2 files changed, 17 insertions(+), 2 deletions(-) > create mode 100644 main/pciutils/fix-linking-pci-malloc-Makefile.patch I fixed commit message to include which package it is about and applied. In future patches, please prefix the first line in commit message with which package it is. Do: main/pciutils: Added -fPIC flag to fix pci_malloc relocation Instead of: Added -fPIC flag to fix pci_malloc relocation The reason is that I use git shortlog to generate release notes. Without the 'main/pciutils:' prefix the release-notes would look something like: Carlo Landmeter (4): testing/py-mopidy-beets: new aport testing/py-mopidy-moped: new aport testing/py-pykka: new aport testing/py-gstreamer0.10: remove duplicate aport Natanael Copa (5): main/openjdk7: remove unused xulrunner from makedepends main/php: build phpdbg main/php: install php-cli as default instead of php-cgi main/php: upgrade to 5.6.2 main/gettext: upgrade to 0.19.3 k0r10n (1): Added -fPIC flag to fix pci_malloc relocation There is nothing in your commit that indicates what was actually fixed. If you do the commit message with 'main/pciutils:' prefix it becomes: Carlo Landmeter (4): testing/py-mopidy-beets: new aport testing/py-mopidy-moped: new aport testing/py-pykka: new aport testing/py-gstreamer0.10: remove duplicate aport Natanael Copa (5): main/openjdk7: remove unused xulrunner from makedepends main/php: build phpdbg main/php: install php-cli as default instead of php-cgi main/php: upgrade to 5.6.2 main/gettext: upgrade to 0.19.3 k0r10n (1): main/pciutils: Added -fPIC flag to fix pci_malloc relocation With the package name in commit message the release-notes (and git log) makes more sense. Thanks! -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---