X-Original-To: alpine-devel@lists.alpinelinux.org Delivered-To: alpine-devel@mail.alpinelinux.org Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133]) (using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mail.alpinelinux.org (Postfix) with ESMTPSA id 7384EDC00C2; Wed, 29 Oct 2014 10:07:12 +0000 (UTC) Date: Wed, 29 Oct 2014 11:07:08 +0100 From: Natanael Copa To: Pierre Peyronnel Cc: alpine-devel@lists.alpinelinux.org Subject: Re: [alpine-devel] [2.7] main/collectd added libvirt sub package Message-ID: <20141029110708.55b59244@ncopa-desktop.alpinelinux.org> In-Reply-To: References: X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-alpine-linux-musl) X-Mailinglist: alpine-devel Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 29 Oct 2014 01:30:14 +0100 Pierre Peyronnel wrote: > Hello everyone, > > just wanted to add libvirt support to collectd and successfully did with > minor modifications. > This should work on edge to i think being so minor a change. We added this to edge already: > > Please find git diff attached, > thanks > > Pierre > NB : i am not subscribed to the list If the package already ships the libvirt plugin, then i don't want add it to any stable branch as it might break things for people using it (til they apk add collectd-libvirt) If its not shipped witih current collectd, then I'd expect to see a configure option ala --enable-libvirt and an additional libvirt-dev to makedepends? If you want additional libvirt support for collectd for v2.7, then please file an issue on bugs.alpinelinux.org. I think it should be doable. Thanks! -nc --- Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org Help: alpine-devel+help@lists.alpinelinux.org ---