X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from ncopa-desktop.alpinelinux.org (unknown [79.160.13.133])
	(using SSLv3 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: n@tanael.org)
	by mail.alpinelinux.org (Postfix) with ESMTPSA id 90BDDDC01DF;
	Mon, 10 Nov 2014 08:07:36 +0000 (UTC)
Date: Mon, 10 Nov 2014 09:07:33 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Isaac Dunham <ibid.ag@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] Move motif to main
Message-ID: <20141110090733.291c4416@ncopa-desktop.alpinelinux.org>
In-Reply-To: <20141109203416.GA1896@newbook>
References: <20141109203416.GA1896@newbook>
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-alpine-linux-musl)
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Sun, 9 Nov 2014 12:34:22 -0800
Isaac Dunham <ibid.ag@gmail.com> wrote:

> In my testing, Motif seems to be working well.
> Is there any objection to moving it to main?
>=20
> The attached patch will move it to main and add myself as=20
> contributor/maintainer, since that was my intent when I submitted it.
>=20
> Thanks,
> Isaac Dunham

just a little tip on how patches with request for comments can be done.


# create a dir dedicated for patches
mkdir -p ~/patches

# create a single patch from HEAD
git format-patch -o ~/patches -1

now edit the created patch and add your comments/questions that you
don't want be included in the commit under the '---'.

For example:

=46rom 15191bb59e1374d830b6f50cf13068130baf9973 Mon Sep 17 00:00:00 2001
From: Natanael Copa <ncopa@alpinelinux.org>
Date: Sun, 9 Nov 2014 19:42:24 +0000
Subject: [PATCH] testing/firefox: upgrade to 33.0.3

---
<insert your comment/question here>
Text here will not be included in commit message.

 testing/firefox/APKBUILD | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/testing/firefox/APKBUILD b/testing/firefox/APKBUILD
index d7b6248..e885fcd 100644
--- a/testing/firefox/APKBUILD
+++ b/testing/firefox/APKBUILD
@@ -1,7 +1,7 @@
 # Contributor: William Pitcock <nenolod@dereferenced.org>
 # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
 pkgname=3Dfirefox
-pkgver=3D33.0.2
+pkgver=3D33.0.3
 _pkgver=3D$pkgver
 _xulver=3D$pkgver
 pkgrel=3D0
@@ -167,7 +167,7 @@ dev() {
...

And after that use:

 git send-email --to alpine-devel@lists.alpinelinux.org ~/patches/0001-test=
ing-.....


An alternate, quicker way to do it is to do:

 git send-email --annotate -1

Which will open a text editor before sending it (but will not save your
changes locally in case you type wrong password for smtp auth)

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---