X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by mail.alpinelinux.org (Postfix) with ESMTPS id 094A9DC0082
	for <alpine-devel@lists.alpinelinux.org>; Wed, 12 Nov 2014 18:36:41 +0000 (UTC)
Received: by mail-pa0-f48.google.com with SMTP id ey11so13491024pad.21
        for <alpine-devel@lists.alpinelinux.org>; Wed, 12 Nov 2014 10:36:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        bh=JrOZ/dx9fIza8qox5nA4k7gEqKZgD6qNR4n+cCWo4+8=;
        b=i0f88XY/pShVKDCBGjR+AtB6uEl/ehL0hZlaglpSBe9W9TfklZEZltlwiN7ZFjrS4E
         GMqjEaHQ8uMlQjf6dGxxQjjq8VBuuSw7eYr50zTgmPAqR5H7AuTsrrywt65jsO+BknCR
         UB/XFucI4SpjJf2KUFn83FTKwVcQmMkdSUPY0t6HXJ8i5RgVpLJ4NkKxSED32rNhsoCZ
         2vi46z6Ayw7v5lW6z52T4gxu2P3Y22DAj/38ItGTnFOdBuyE2SX2vttAMU26KNgTcSJX
         erbZ/wXRkah4JtxS8EZjvRxV0y5SBmn69F+nM2mADYLtREzs5533g8+/UzllVFCTEzRN
         PsuQ==
X-Received: by 10.70.134.74 with SMTP id pi10mr14903826pdb.126.1415817400902;
        Wed, 12 Nov 2014 10:36:40 -0800 (PST)
Received: from newbook ([50.0.227.65])
        by mx.google.com with ESMTPSA id b1sm22792308pdj.76.2014.11.12.10.36.39
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 12 Nov 2014 10:36:40 -0800 (PST)
Date: Wed, 12 Nov 2014 10:36:46 -0800
From: Isaac Dunham <ibid.ag@gmail.com>
To: AmatCoder <amatcoder@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/mednafen: new aport
Message-ID: <20141112183645.GA1861@newbook>
References: <1415813332-3112-1-git-send-email-amatcoder@gmail.com>
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1415813332-3112-1-git-send-email-amatcoder@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

On Wed, Nov 12, 2014 at 05:28:52PM +0000, AmatCoder wrote:
> --- /dev/null
> +++ b/testing/mednafen/01-fix_help.patch
> @@ -0,0 +1,25 @@
> +--- origin/src/drivers/main.cpp
> ++++ mednafen/src/drivers/main.cpp
> +@@ -696,7 +696,7 @@
> + 	if(argc <= 1)
> + 	{
> + 	 printf(_("No command-line arguments specified.\n\n"));
> +-	 printf(usage_string, argv[0]);
> ++	 printf(usage_string, "/usr/bin/mednafen");
> 
It looks like this diff is basically 's_argv[0]_"/usr/bin/mednafen"_g'

And I'm wondering what the benefit of that is, because every program
I have seen uses argv[0], a synonym thereof, or even basename(argv[0]). 
In fact, *not* having the full path unless it was specified is something
I'd find desireable enough to justify a patch.

Thanks,
Isaac Dunham




---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---