Date: Mon, 17 Nov 2014 08:59:05 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Johannes Matheis <jomat+alpinebuild@jmt.gr>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] [PATCH] testing/lua-event: new aport
Message-ID: <20141117085905.00a0deea@ncopa-desktop.alpinelinux.org>
In-Reply-To: <20141115223446.31094.53607@leto.j.dn42>
References: <20141115223446.31094.53607@leto.j.dn42>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sat, 15 Nov 2014 18:30:01 +0000
Johannes Matheis <jomat+alpinebuild@jmt.gr> wrote:

> https://github.com/harningt/luaevent
> Lua binding for libevent
> 
> Patch available from:
> https://github.com/jomat/aports/commit/814b26503d01cbdbbde9ca3f7d3eefb81584bb15.patch
> 
> 
> ---
> Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
> Help:         alpine-devel+help@lists.alpinelinux.org
> ---
> 

Applied. Thanks!

Do you know if they support lua 5.2 too?

btw, this will cause problems:

> source="${url}/archive/v${pkgver}.tar.gz"

The source package will be "v0.4.3.tar.gz". What will happen if we do
that with all packages and at some point 2 different packages from
github happens to have same version number?

answer: the source tarball file name will collide because all packages
share the download cache dir.

We need to avoid that so the proper thing to do is save it with a more
unique name:

source="$pkgname-$pkgver.tar.gz::${url}/archive/v${pkgver}.tar.gz"

I fixed it and added support for Lua 5.2.

Thanks!

-nc


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---