X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@mail.alpinelinux.org
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53])
	(using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
	(No client certificate requested)
	by mail.alpinelinux.org (Postfix) with ESMTPS id 48F86DC00CA
	for <alpine-devel@lists.alpinelinux.org>; Tue, 18 Nov 2014 17:43:07 +0000 (UTC)
Received: by mail-pa0-f53.google.com with SMTP id kq14so5985190pab.26
        for <alpine-devel@lists.alpinelinux.org>; Tue, 18 Nov 2014 09:43:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        bh=a5qsnzdxDwVCOc48pirqXUtF35HEiJ3yevEHkI3oGJs=;
        b=vc0HX6xElRR81Ttm4cR4h1lvEKtxzLhlZIQdWQZU+TaQnZxte3r8oJzzJgd/k63IWt
         qHjgVtuT2A4DCgCd8XsTNtG25UGgIvt7yDAJT5j1DXEHYvfd03oLuE9QN5dyKHuyvPe/
         ueLersZE+aHIl8TPnj7lbJBvG726tELv3bjWYh2R2aVdjjd+y9u1Cn6F1t+2iHaSyFDV
         n2fE/dfrVxjUoYPcoNjvm1L0TFqCXbjZDrRRG1g6XjKpxZLaZw4NRYD27PML9tzYYORP
         v1OAoRP3AZ5hIMDCrGklqzYNR0WBym8OgFO8RtmyiTvynaAS/e/24HYbOSSeD8Sxf58w
         Pwvg==
X-Received: by 10.66.119.237 with SMTP id kx13mr38097818pab.5.1416332586513;
        Tue, 18 Nov 2014 09:43:06 -0800 (PST)
Received: from newbook ([50.0.227.65])
        by mx.google.com with ESMTPSA id cs6sm11142696pdb.5.2014.11.18.09.43.05
        for <multiple recipients>
        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Tue, 18 Nov 2014 09:43:05 -0800 (PST)
Date: Tue, 18 Nov 2014 09:43:13 -0800
From: Isaac Dunham <ibid.ag@gmail.com>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: alpine-devel@lists.alpinelinux.org
Subject: Re: [alpine-devel] Re: fltk upgrades, dillo, other packages...
Message-ID: <20141118174312.GA2253@newbook>
References: <20141117061026.GA1552@newbook>
 <20141117074618.GB1552@newbook>
 <20141118094344.3822d5cf@ncopa-desktop.alpinelinux.org>
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141118094344.3822d5cf@ncopa-desktop.alpinelinux.org>
User-Agent: Mutt/1.5.23 (2014-03-12)

On Tue, Nov 18, 2014 at 09:43:44AM +0100, Natanael Copa wrote:
> On Sun, 16 Nov 2014 23:46:19 -0800
> Isaac Dunham <ibid.ag@gmail.com> wrote:
> 
> > On Sun, Nov 16, 2014 at 10:10:26PM -0800, Isaac Dunham wrote:
> > > Hello,
> > > I'm working on getting WebkitFLTK[1] to build, so as to build Fifth,
> > > which is yet another Webkit browser--this time, it's loosely based on
> > > Opera 9.x and uses FLTK.

The source builds now with a local FLTK 1.3.3 upgrade and a few small
changes that have been merged already; the final link doesn't work, 
since it tries to link harfbuzz and ICU statically.
I've hacked it a little so that it doesn't do that, but it's not a 
change fit to push or package (delete -Wl,-Bstatic from one makefile);
a proper fix needs more work.

I need to package physfs (in progress) and liburlmatch (builds fine)
at least before Fifth will build.

> > > WebkitFLTK requires FLTK 1.3.3, while we have 1.3.2.
> > > There are some issues with doing an upgrade:
> > > -1.3.3 has a couple bugs fixed in SVN; this is easily addressed by 
> > > grabbing the patches.
> > > -1.3.3 also is now missing the symbol "fl_oldfocus" (and possibly others),
> > > which will break dillo. It does *not* change the library version.
> > > I have looked through the commit logs and looked online, and there's 
> > > no obvious candidate for what caused the issue.
> > > The dillo developers are guessing that linker magic might have caused it; 
> > > they have a workaround that involves disabling the use of fl_oldfocus, 
> > > at the cost of not restoring focus properly.
> > > 
> > 
> > -fvisibility=hidden is the culprit; FLTK started using it this summer.
> > Building with -fvisibility-inlines-hidden instead seems to avoid this.
> 
> This sounds like a bug in FLTK (or dillo).
> 
> Either fl_oldfocus symbol should be marked visible for dillo to use, or
> the fl_oldfocus is not exported and not supposed to be used outside
> FLTK itself - in which case dillo shouldnt use it.
> 
> googling around i found this:
> 
> https://www.mail-archive.com/gentoo-commits@lists.gentoo.org/msg68829.html
> Index: fltk-1.3.3-visibility.patch
> ===================================================================
> --- a/src/Fl.cxx
> +++ b/src/Fl.cxx
> @@ -928,7 +928,7 @@
>  
>  ////////////////////////////////////////////////////////////////
>  
> -Fl_Widget* fl_oldfocus; // kludge for Fl_Group...
> +FL_EXPORT Fl_Widget* fl_oldfocus; // kludge for Fl_Group...
>  
>  /**
>      Sets the widget that will receive FL_KEYBOARD events.
> 
> 
> Which seems to make the fl_oldfocus visible. I think this is the way to go...

I ran across that last night.

But one of the FLTK developers says fl_oldfocus should not be public;
there was a workaround in hg that left dillo in worse shape[1], but
there is now a proper fix[2].

dillo has some other fixes, and I need to find at least one commit 
in FLTK trunk providing a fix for an unrelated issue: some packages 
we don't provide yet had serious bugs caused by FLTK 1.3.3.


Thanks,
Isaac Dunham


[1] http://hg.dillo.org/dillo/rev/a012eab2c057
[2] http://hg.dillo.org/dillo/rev/eb902ac9fc66


---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---